* [PATCH] OMAP:DISPC Register name typo
@ 2008-05-07 7:30 arun c
2008-05-07 23:22 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: arun c @ 2008-05-07 7:30 UTC (permalink / raw)
To: linux-omap
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
Hi all,
This patch corrects the register name typo in dispc.c.
False read happens just after the reset(reading DISPC_CONTROL returns
zero), this
might be the reason it worked fine without any issue.
############################################
>From 8734c18115caf53121c46002983b6c4763bd7f2b Mon Sep 17 00:00:00 2001
From: arun <arunedarath@mistralsolutions.com>
Date: Wed, 7 May 2008 12:25:40 +0530
Subject: [PATCH] OMAP:DISPC Register name typo
DISPC_CONTROL was used instead of DISPC_SYSCONFIG.
Signed-off-by: arun <arunedarath@mistralsolutions.com>
---
drivers/video/omap/dispc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c
index 4c055a2..6aff476 100644
--- a/drivers/video/omap/dispc.c
+++ b/drivers/video/omap/dispc.c
@@ -1393,7 +1393,7 @@ static int omap_dispc_init(struct omapfb_device
*fbdev, int ext_mode,
}
/* Enable smart idle and autoidle */
- l = dispc_read_reg(DISPC_CONTROL);
+ l = dispc_read_reg(DISPC_SYSCONFIG);
l &= ~((3 << 12) | (3 << 3));
l |= (2 << 12) | (2 << 3) | (1 << 0);
dispc_write_reg(DISPC_SYSCONFIG, l);
--
1.5.3.4
##########################################
Regards,
Arun C
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-OMAP-DISPC-Register-name-typo.patch --]
[-- Type: text/x-patch; name=0001-OMAP-DISPC-Register-name-typo.patch, Size: 904 bytes --]
From 8734c18115caf53121c46002983b6c4763bd7f2b Mon Sep 17 00:00:00 2001
From: arun <arunedarath@mistralsolutions.com>
Date: Wed, 7 May 2008 12:25:40 +0530
Subject: [PATCH] OMAP:DISPC Register name typo
DISPC_CONTROL was used instead of DISPC_SYSCONFIG.
Signed-off-by: arun <arunedarath@mistralsolutions.com>
---
drivers/video/omap/dispc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c
index 4c055a2..6aff476 100644
--- a/drivers/video/omap/dispc.c
+++ b/drivers/video/omap/dispc.c
@@ -1393,7 +1393,7 @@ static int omap_dispc_init(struct omapfb_device *fbdev, int ext_mode,
}
/* Enable smart idle and autoidle */
- l = dispc_read_reg(DISPC_CONTROL);
+ l = dispc_read_reg(DISPC_SYSCONFIG);
l &= ~((3 << 12) | (3 << 3));
l |= (2 << 12) | (2 << 3) | (1 << 0);
dispc_write_reg(DISPC_SYSCONFIG, l);
--
1.5.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OMAP:DISPC Register name typo
2008-05-07 7:30 [PATCH] OMAP:DISPC Register name typo arun c
@ 2008-05-07 23:22 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2008-05-07 23:22 UTC (permalink / raw)
To: arun c; +Cc: linux-omap
* arun c <arunedarath@mistralsolutions.com> [080507 00:31]:
> Hi all,
>
> This patch corrects the register name typo in dispc.c.
> False read happens just after the reset(reading DISPC_CONTROL returns
> zero), this
> might be the reason it worked fine without any issue.
Pushing today.
Tony
> ############################################
> From 8734c18115caf53121c46002983b6c4763bd7f2b Mon Sep 17 00:00:00 2001
> From: arun <arunedarath@mistralsolutions.com>
> Date: Wed, 7 May 2008 12:25:40 +0530
> Subject: [PATCH] OMAP:DISPC Register name typo
>
> DISPC_CONTROL was used instead of DISPC_SYSCONFIG.
>
> Signed-off-by: arun <arunedarath@mistralsolutions.com>
> ---
> drivers/video/omap/dispc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c
> index 4c055a2..6aff476 100644
> --- a/drivers/video/omap/dispc.c
> +++ b/drivers/video/omap/dispc.c
> @@ -1393,7 +1393,7 @@ static int omap_dispc_init(struct omapfb_device
> *fbdev, int ext_mode,
> }
>
> /* Enable smart idle and autoidle */
> - l = dispc_read_reg(DISPC_CONTROL);
> + l = dispc_read_reg(DISPC_SYSCONFIG);
> l &= ~((3 << 12) | (3 << 3));
> l |= (2 << 12) | (2 << 3) | (1 << 0);
> dispc_write_reg(DISPC_SYSCONFIG, l);
> --
> 1.5.3.4
>
> ##########################################
>
> Regards,
> Arun C
> From 8734c18115caf53121c46002983b6c4763bd7f2b Mon Sep 17 00:00:00 2001
> From: arun <arunedarath@mistralsolutions.com>
> Date: Wed, 7 May 2008 12:25:40 +0530
> Subject: [PATCH] OMAP:DISPC Register name typo
>
> DISPC_CONTROL was used instead of DISPC_SYSCONFIG.
>
> Signed-off-by: arun <arunedarath@mistralsolutions.com>
> ---
> drivers/video/omap/dispc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c
> index 4c055a2..6aff476 100644
> --- a/drivers/video/omap/dispc.c
> +++ b/drivers/video/omap/dispc.c
> @@ -1393,7 +1393,7 @@ static int omap_dispc_init(struct omapfb_device *fbdev, int ext_mode,
> }
>
> /* Enable smart idle and autoidle */
> - l = dispc_read_reg(DISPC_CONTROL);
> + l = dispc_read_reg(DISPC_SYSCONFIG);
> l &= ~((3 << 12) | (3 << 3));
> l |= (2 << 12) | (2 << 3) | (1 << 0);
> dispc_write_reg(DISPC_SYSCONFIG, l);
> --
> 1.5.3.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-07 23:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-07 7:30 [PATCH] OMAP:DISPC Register name typo arun c
2008-05-07 23:22 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox