From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/5] sparse, checkpatch cleanup in mach-omap2
Date: Fri, 9 May 2008 14:42:28 -0700 [thread overview]
Message-ID: <20080509214227.GB5976@atomide.com> (raw)
In-Reply-To: <20080507171204.17732.97601.stgit@localhost.localdomain>
* Paul Walmsley <paul@pwsan.com> [080507 12:51]:
> It's springtime in the Northern Hemisphere; time for plants to flower,
> students to graduate, or not, and Linux hackers to generate cleanup
> patches against the source tree...
>
> These patches fix all of the sparse warnings against the
> arch/arm/mach-omap2 directory, and fix some of the checkpatch.pl
> warnings also. The individual patch descriptions discuss the main
> changes involved. sparse did find a few stinkers - I think the worst
> was a shadowed variable in clock.c.
>
> There are a few other minor changes involved. The main one was that
> the unlikely() and likely() branch predictor hints got removed.
>
> The sparse fixes do have one downside: some additional uglification, caused
> by the addition of __force to pointer->integer and integer->pointer casts.
> The rest of the kernel seems to have accepted this tradeoff.
>
> Compile-tested with OSK5912, N800, 2430SDP, and 3430SDP configs;
> boot-tested on 3430SDP ES2.
Pushing today.
Tony
>
>
> - Paul
>
> ---
>
> diffstat:
> arch/arm/mach-omap2/clock.c | 107 ++++++++++++++---------------
> arch/arm/mach-omap2/clock.h | 4 +
> arch/arm/mach-omap2/clock24xx.c | 23 +++---
> arch/arm/mach-omap2/clockdomain.c | 5 +
> arch/arm/mach-omap2/cm.h | 4 +
> arch/arm/mach-omap2/control.c | 13 ++--
> arch/arm/mach-omap2/devices.c | 10 +--
> arch/arm/mach-omap2/gpmc.c | 42 ++++++-----
> arch/arm/mach-omap2/id.c | 9 +-
> arch/arm/mach-omap2/io.c | 15 ++--
> arch/arm/mach-omap2/irq.c | 58 ++++++++++------
> arch/arm/mach-omap2/memory.h | 7 ++
> arch/arm/mach-omap2/mux.c | 14 ++--
> arch/arm/mach-omap2/pm.c | 37 ++++++----
> arch/arm/mach-omap2/powerdomain.c | 2 -
> arch/arm/mach-omap2/prcm.c | 12 ++-
> arch/arm/mach-omap2/prm.h | 6 +-
> arch/arm/mach-omap2/sdrc.h | 4 +
> arch/arm/mach-omap2/serial.c | 21 +++---
> arch/arm/mach-omap2/usb-ehci.c | 2 -
> include/asm-arm/arch-omap/board-3430sdp.h | 1
> include/asm-arm/arch-omap/board.h | 6 +-
> include/asm-arm/arch-omap/clock.h | 7 +-
> include/asm-arm/arch-omap/control.h | 16 ++--
> include/asm-arm/arch-omap/cpu.h | 6 +-
> include/asm-arm/arch-omap/mmc.h | 4 +
> include/asm-arm/arch-omap/omap24xx.h | 1
> include/asm-arm/arch-omap/omapfb.h | 1
> include/asm-arm/arch-omap/powerdomain.h | 1
> include/asm-arm/arch-omap/prcm.h | 5 +
> include/asm-arm/arch-omap/sram.h | 1
> include/asm-arm/arch-omap/system.h | 4 +
> include/asm-arm/arch-omap/timex.h | 2 +
> include/asm-arm/arch-omap/usb.h | 3 +
> 34 files changed, 247 insertions(+), 206 deletions(-)
>
> size:
> text data bss dec hex filename
> 3271533 155216 101256 3528005 35d545 vmlinux.3430sdp.orig
> 3271501 155216 101256 3527973 35d525 vmlinux.3430sdp.patched
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-05-09 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 17:52 [PATCH 0/5] sparse, checkpatch cleanup in mach-omap2 Paul Walmsley
2008-05-07 17:52 ` [PATCH 1/5] fix sparse, checkpatch warnings in OMAP2/3 PRCM/PM code Paul Walmsley
2008-05-07 17:52 ` [PATCH 2/5] fix sparse, checkpatch warnings in OMAP2/3 SMS/GPMC/SRAM code Paul Walmsley
2008-05-07 17:52 ` [PATCH 3/5] fix sparse, checkpatch warnings in OMAP2/3 IRQ code Paul Walmsley
2008-05-07 17:52 ` [PATCH 5/5] Fix remaining sparse warnings in arch/arm/mach-omap2 Paul Walmsley
2008-05-07 17:52 ` [PATCH 4/5] fix sparse, checkpatch warnings in OMAP2/3 SCM code Paul Walmsley
2008-05-09 21:42 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080509214227.GB5976@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox