* [PATCH 0/2] OMAP3 clock: two small fixes
@ 2008-05-08 1:19 Paul Walmsley
2008-05-08 1:19 ` [PATCH 1/2] OMAP3 clock: move sys_clkout2 clk to core_clkdm Paul Walmsley
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Paul Walmsley @ 2008-05-08 1:19 UTC (permalink / raw)
To: linux-omap
Two minor OMAP3 clock framework fixes. This series:
- puts the sys_clkout2 struct clk into the core_clkdm where it belongs
- removes the omap2_noncore_dpll_set_rate() function pointer from the
DPLL3 struct clk (since DPLL3 is the CORE DPLL)
- Paul
---
arch/arm/mach-omap2/clock34xx.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/2] OMAP3 clock: move sys_clkout2 clk to core_clkdm
2008-05-08 1:19 [PATCH 0/2] OMAP3 clock: two small fixes Paul Walmsley
@ 2008-05-08 1:19 ` Paul Walmsley
2008-05-08 1:19 ` [PATCH 2/2] OMAP3 clock: remove omap3_noncore_dpll_set_rate fn from CORE DPLL definition Paul Walmsley
2008-05-09 21:46 ` [PATCH 0/2] OMAP3 clock: two small fixes Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2008-05-08 1:19 UTC (permalink / raw)
To: linux-omap
sys_clkout2 belongs in the core_clkdm (3430 TRM section 4.7.2.2).
It's not clear whether it actually is in the CORE clockdomain, or whether
it is technically in a different clockdomain; but this is closer to
reality than the present configuration.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
arch/arm/mach-omap2/clock34xx.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/clock34xx.h b/arch/arm/mach-omap2/clock34xx.h
index 85afe1e..825bab4 100644
--- a/arch/arm/mach-omap2/clock34xx.h
+++ b/arch/arm/mach-omap2/clock34xx.h
@@ -978,6 +978,7 @@ static struct clk clkout2_src_ck = {
.clksel_mask = OMAP3430_CLKOUT2SOURCE_MASK,
.clksel = clkout2_src_clksel,
.flags = CLOCK_IN_OMAP343X | RATE_PROPAGATES,
+ .clkdm_name = "core_clkdm",
.recalc = &omap2_clksel_recalc,
};
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] OMAP3 clock: remove omap3_noncore_dpll_set_rate fn from CORE DPLL definition
2008-05-08 1:19 [PATCH 0/2] OMAP3 clock: two small fixes Paul Walmsley
2008-05-08 1:19 ` [PATCH 1/2] OMAP3 clock: move sys_clkout2 clk to core_clkdm Paul Walmsley
@ 2008-05-08 1:19 ` Paul Walmsley
2008-05-09 21:46 ` [PATCH 0/2] OMAP3 clock: two small fixes Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2008-05-08 1:19 UTC (permalink / raw)
To: linux-omap
DPLL3 is the CORE DPLL and cannot use the non-CORE set_rate function since
SDRC is downstream.
Signed-off-by: Paul Walmslsy <paul@pwsan.com>
---
arch/arm/mach-omap2/clock34xx.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/clock34xx.h b/arch/arm/mach-omap2/clock34xx.h
index 825bab4..284c796 100644
--- a/arch/arm/mach-omap2/clock34xx.h
+++ b/arch/arm/mach-omap2/clock34xx.h
@@ -411,7 +411,6 @@ static struct clk dpll3_ck = {
.dpll_data = &dpll3_dd,
.flags = CLOCK_IN_OMAP343X | RATE_PROPAGATES | ALWAYS_ENABLED,
.round_rate = &omap2_dpll_round_rate,
- .set_rate = &omap3_noncore_dpll_set_rate,
.recalc = &omap3_dpll_recalc,
};
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 0/2] OMAP3 clock: two small fixes
2008-05-08 1:19 [PATCH 0/2] OMAP3 clock: two small fixes Paul Walmsley
2008-05-08 1:19 ` [PATCH 1/2] OMAP3 clock: move sys_clkout2 clk to core_clkdm Paul Walmsley
2008-05-08 1:19 ` [PATCH 2/2] OMAP3 clock: remove omap3_noncore_dpll_set_rate fn from CORE DPLL definition Paul Walmsley
@ 2008-05-09 21:46 ` Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2008-05-09 21:46 UTC (permalink / raw)
To: Paul Walmsley; +Cc: linux-omap
* Paul Walmsley <paul@pwsan.com> [080507 18:29]:
> Two minor OMAP3 clock framework fixes. This series:
>
> - puts the sys_clkout2 struct clk into the core_clkdm where it belongs
>
> - removes the omap2_noncore_dpll_set_rate() function pointer from the
> DPLL3 struct clk (since DPLL3 is the CORE DPLL)
Pushing.
Tony
>
>
> - Paul
>
> ---
>
> arch/arm/mach-omap2/clock34xx.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-09 21:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-08 1:19 [PATCH 0/2] OMAP3 clock: two small fixes Paul Walmsley
2008-05-08 1:19 ` [PATCH 1/2] OMAP3 clock: move sys_clkout2 clk to core_clkdm Paul Walmsley
2008-05-08 1:19 ` [PATCH 2/2] OMAP3 clock: remove omap3_noncore_dpll_set_rate fn from CORE DPLL definition Paul Walmsley
2008-05-09 21:46 ` [PATCH 0/2] OMAP3 clock: two small fixes Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox