* [PATCH] ARM: OMAP: add RTC support to beagleboard @ 2008-05-08 16:35 Koen Kooi 2008-05-08 16:53 ` Steve Sakoman 2008-05-08 16:55 ` andrzej zaborowski 0 siblings, 2 replies; 8+ messages in thread From: Koen Kooi @ 2008-05-08 16:35 UTC (permalink / raw) To: linux-omap; +Cc: Khasim Syed Mohammed, Beagle Board This patch adds RTC support to the omap3 based beagleboard Signed-off-by: Koen Kooi <koen@openembedded.org> --- arch/arm/mach-omap2/board-omap3beagle.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach- omap2/board-omap3beagle.c index 626f004..e7b471b 100644 --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c @@ -58,11 +58,22 @@ static struct omap_mmc_config omap3beagle_mmc_config __initdata = { }, }; +static struct platform_device omap3_beagle_twl4030rtc_device = { + .name = "twl4030_rtc", + .id = -1, +}; + static struct omap_board_config_kernel omap3_beagle_config[] __initdata = { { OMAP_TAG_UART, &omap3_beagle_uart_config }, { OMAP_TAG_MMC, &omap3beagle_mmc_config }, }; +static struct platform_device *omap3_beagle_devices[] __initdata = { +#ifdef CONFIG_RTC_DRV_TWL4030 + &omap3_beagle_twl4030rtc_device, +#endif +}; + static void __init omap3_beagle_init(void) { omap_board_config = omap3_beagle_config; -- 1.5.4.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: OMAP: add RTC support to beagleboard 2008-05-08 16:35 [PATCH] ARM: OMAP: add RTC support to beagleboard Koen Kooi @ 2008-05-08 16:53 ` Steve Sakoman 2008-05-08 16:55 ` andrzej zaborowski 1 sibling, 0 replies; 8+ messages in thread From: Steve Sakoman @ 2008-05-08 16:53 UTC (permalink / raw) To: Koen Kooi; +Cc: linux-omap, Khasim Syed Mohammed, Beagle Board I've reviewed this patch and based upon my experience with the OMAP3 EVM believe it should also work on the beagleboard. Acked-by: Steve Sakoman <steve@sakoman.com> On Thu, May 8, 2008 at 9:35 AM, Koen Kooi <k.kooi@student.utwente.nl> wrote: > This patch adds RTC support to the omap3 based beagleboard > > Signed-off-by: Koen Kooi <koen@openembedded.org> > --- > arch/arm/mach-omap2/board-omap3beagle.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c > b/arch/arm/mach-omap2/board-omap3beagle.c > index 626f004..e7b471b 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -58,11 +58,22 @@ static struct omap_mmc_config omap3beagle_mmc_config > __initdata = { > }, > }; > > +static struct platform_device omap3_beagle_twl4030rtc_device = { > + .name = "twl4030_rtc", > + .id = -1, > +}; > + > static struct omap_board_config_kernel omap3_beagle_config[] __initdata = > { > { OMAP_TAG_UART, &omap3_beagle_uart_config }, > { OMAP_TAG_MMC, &omap3beagle_mmc_config }, > }; > > +static struct platform_device *omap3_beagle_devices[] __initdata = { > +#ifdef CONFIG_RTC_DRV_TWL4030 > + &omap3_beagle_twl4030rtc_device, > +#endif > +}; > + > static void __init omap3_beagle_init(void) > { > omap_board_config = omap3_beagle_config; > -- > 1.5.4.3 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: OMAP: add RTC support to beagleboard 2008-05-08 16:35 [PATCH] ARM: OMAP: add RTC support to beagleboard Koen Kooi 2008-05-08 16:53 ` Steve Sakoman @ 2008-05-08 16:55 ` andrzej zaborowski 2008-05-08 17:04 ` Koen Kooi 1 sibling, 1 reply; 8+ messages in thread From: andrzej zaborowski @ 2008-05-08 16:55 UTC (permalink / raw) To: Koen Kooi; +Cc: linux-omap, Khasim Syed Mohammed, Beagle Board On 08/05/2008, Koen Kooi <k.kooi@student.utwente.nl> wrote: > This patch adds RTC support to the omap3 based beagleboard > > Signed-off-by: Koen Kooi <koen@openembedded.org> > --- > arch/arm/mach-omap2/board-omap3beagle.c | 11 > +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c > b/arch/arm/mach-omap2/board-omap3beagle.c > index 626f004..e7b471b 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -58,11 +58,22 @@ static struct omap_mmc_config omap3beagle_mmc_config > __initdata = { > }, > }; > > +static struct platform_device omap3_beagle_twl4030rtc_device = { > + .name = "twl4030_rtc", > + .id = -1, > +}; > + > static struct omap_board_config_kernel omap3_beagle_config[] __initdata = > { > { OMAP_TAG_UART, &omap3_beagle_uart_config }, > { OMAP_TAG_MMC, &omap3beagle_mmc_config }, > }; > > +static struct platform_device *omap3_beagle_devices[] __initdata = { > +#ifdef CONFIG_RTC_DRV_TWL4030 > + &omap3_beagle_twl4030rtc_device, > +#endif > +}; > + > static void __init omap3_beagle_init(void) > { > omap_board_config = omap3_beagle_config; > -- > 1.5.4.3 Something must be missing here, omap3_beagle_devices is not being referenced. The missing line probably looks something like platform_add_devices(omap3_beagle_devices, ARRAY_SIZE(omap3_beagle_devices)); You can also add the #ifdef around omap3_beagle_twl4030rtc_device to avoid a compiler warning, or drop it in both places. Regards -- Please do not print this email unless absolutely necessary. Spread environmental awareness. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: OMAP: add RTC support to beagleboard 2008-05-08 16:55 ` andrzej zaborowski @ 2008-05-08 17:04 ` Koen Kooi 2008-05-09 14:49 ` Koen Kooi 0 siblings, 1 reply; 8+ messages in thread From: Koen Kooi @ 2008-05-08 17:04 UTC (permalink / raw) To: linux-omap; +Cc: Beagle Board -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Op 8 mei 2008, om 18:55 heeft andrzej zaborowski het volgende geschreven: > Something must be missing here, omap3_beagle_devices is not being > referenced. > > The missing line probably looks something like > platform_add_devices(omap3_beagle_devices, > ARRAY_SIZE(omap3_beagle_devices)); You're 100% right :) I forgot --amend, so the patch missed my second commit > You can also add the #ifdef around omap3_beagle_twl4030rtc_device to > avoid a compiler warning, or drop it in both places. The idea is that a next patch (rudimentary lcd support) will add device in there as well. I can move the ifdef for this patch if you want. thanks for the review, Koen Updated patch: This patch adds RTC support to the omap3 based beagleboard Signed-off-by: Koen Kooi <koen@openembedded.org> - --- arch/arm/mach-omap2/board-omap3beagle.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach- omap2/board-omap3beagle.c index 626f004..0c0cbfc 100644 - --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c @@ -58,13 +58,25 @@ static struct omap_mmc_config omap3beagle_mmc_config __initdata = { }, }; +static struct platform_device omap3_beagle_twl4030rtc_device = { + .name = "twl4030_rtc", + .id = -1, +}; + static struct omap_board_config_kernel omap3_beagle_config[] __initdata = { { OMAP_TAG_UART, &omap3_beagle_uart_config }, { OMAP_TAG_MMC, &omap3beagle_mmc_config }, }; +static struct platform_device *omap3_beagle_devices[] __initdata = { +#ifdef CONFIG_RTC_DRV_TWL4030 + &omap3_beagle_twl4030rtc_device, +#endif +}; + static void __init omap3_beagle_init(void) { + platform_add_devices(omap3_beagle_devices, ARRAY_SIZE(omap3_beagle_devices)); omap_board_config = omap3_beagle_config; omap_board_config_size = ARRAY_SIZE(omap3_beagle_config); omap_serial_init(); - -- 1.5.4.3 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFIIzK8MkyGM64RGpERAgE7AJ9meokVhJ/V/iR3PfwNbf0ZeR0aDACcDP2/ 2kdpcssXcbftzzC5o6D2mLU= =dk6K -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: OMAP: add RTC support to beagleboard 2008-05-08 17:04 ` Koen Kooi @ 2008-05-09 14:49 ` Koen Kooi 2008-05-09 21:54 ` Tony Lindgren 0 siblings, 1 reply; 8+ messages in thread From: Koen Kooi @ 2008-05-09 14:49 UTC (permalink / raw) To: linux-omap; +Cc: Beagle Board -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Op 8 mei 2008, om 19:04 heeft Koen Kooi het volgende geschreven: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > Op 8 mei 2008, om 18:55 heeft andrzej zaborowski het volgende > geschreven: >> Something must be missing here, omap3_beagle_devices is not being >> referenced. >> >> The missing line probably looks something like >> platform_add_devices(omap3_beagle_devices, >> ARRAY_SIZE(omap3_beagle_devices)); > > You're 100% right :) I forgot --amend, so the patch missed my second > commit > >> You can also add the #ifdef around omap3_beagle_twl4030rtc_device to >> avoid a compiler warning, or drop it in both places. > > The idea is that a next patch (rudimentary lcd support) will add > device in there as well. I can move the ifdef for this patch if you > want. > > thanks for the review, > > Koen > > Updated patch: With the current patch I get this in the bootlog: usb0: RNDIS ready mice: PS/2 mouse device common for all mice twl4030_rtc twl4030_rtc: rtc core: registered twl4030_rtc as rtc0 OMAP Watchdog Timer Rev 0x31: initial timeout 60 sec [..] twl4030_rtc twl4030_rtc: setting system clock to 2000-01-01 00:02:15 UTC (946684935) So it works :) regards, Koen > > > This patch adds RTC support to the omap3 based beagleboard > > Signed-off-by: Koen Kooi <koen@openembedded.org> > - --- > arch/arm/mach-omap2/board-omap3beagle.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach- > omap2/board-omap3beagle.c > index 626f004..0c0cbfc 100644 > - --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -58,13 +58,25 @@ static struct omap_mmc_config > omap3beagle_mmc_config __initdata = { > }, > }; > > +static struct platform_device omap3_beagle_twl4030rtc_device = { > + .name = "twl4030_rtc", > + .id = -1, > +}; > + > static struct omap_board_config_kernel omap3_beagle_config[] > __initdata = { > { OMAP_TAG_UART, &omap3_beagle_uart_config }, > { OMAP_TAG_MMC, &omap3beagle_mmc_config }, > }; > > +static struct platform_device *omap3_beagle_devices[] __initdata = { > +#ifdef CONFIG_RTC_DRV_TWL4030 > + &omap3_beagle_twl4030rtc_device, > +#endif > +}; > + > static void __init omap3_beagle_init(void) > { > + platform_add_devices(omap3_beagle_devices, > ARRAY_SIZE(omap3_beagle_devices)); > omap_board_config = omap3_beagle_config; > omap_board_config_size = ARRAY_SIZE(omap3_beagle_config); > omap_serial_init(); > - -- > 1.5.4.3 > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.5 (Darwin) > > iD8DBQFIIzK8MkyGM64RGpERAgE7AJ9meokVhJ/V/iR3PfwNbf0ZeR0aDACcDP2/ > 2kdpcssXcbftzzC5o6D2mLU= > =dk6K > -----END PGP SIGNATURE----- > -- > To unsubscribe from this list: send the line "unsubscribe linux- > omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFIJGR5MkyGM64RGpERAozLAJ9p3ee94zhiX5NKOr1/8Sv5v/YBXwCePaRS /hoiJjfbEV+rHBnnxc1wKak= =nRIx -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: OMAP: add RTC support to beagleboard 2008-05-09 14:49 ` Koen Kooi @ 2008-05-09 21:54 ` Tony Lindgren 2008-05-12 21:54 ` Koen Kooi 0 siblings, 1 reply; 8+ messages in thread From: Tony Lindgren @ 2008-05-09 21:54 UTC (permalink / raw) To: Koen Kooi; +Cc: linux-omap, Beagle Board * Koen Kooi <k.kooi@student.utwente.nl> [080509 07:56]: > > Op 8 mei 2008, om 19:04 heeft Koen Kooi het volgende geschreven: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > > > Op 8 mei 2008, om 18:55 heeft andrzej zaborowski het volgende > > geschreven: > >> Something must be missing here, omap3_beagle_devices is not being > >> referenced. > >> > >> The missing line probably looks something like > >> platform_add_devices(omap3_beagle_devices, > >> ARRAY_SIZE(omap3_beagle_devices)); > > > > You're 100% right :) I forgot --amend, so the patch missed my second > > commit > > > >> You can also add the #ifdef around omap3_beagle_twl4030rtc_device to > >> avoid a compiler warning, or drop it in both places. > > > > The idea is that a next patch (rudimentary lcd support) will add > > device in there as well. I can move the ifdef for this patch if you > > want. > > > > thanks for the review, > > > > Koen > > > > Updated patch: > > With the current patch I get this in the bootlog: > > usb0: RNDIS ready > mice: PS/2 mouse device common for all mice > twl4030_rtc twl4030_rtc: rtc core: registered twl4030_rtc as rtc0 > OMAP Watchdog Timer Rev 0x31: initial timeout 60 sec > [..] > twl4030_rtc twl4030_rtc: setting system clock to 2000-01-01 00:02:15 > UTC (946684935) > > So it works :) Pushing today. Tony > > regards, > > Koen > > > > > > > > This patch adds RTC support to the omap3 based beagleboard > > > > Signed-off-by: Koen Kooi <koen@openembedded.org> > > - --- > > arch/arm/mach-omap2/board-omap3beagle.c | 12 ++++++++++++ > > 1 files changed, 12 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach- > > omap2/board-omap3beagle.c > > index 626f004..0c0cbfc 100644 > > - --- a/arch/arm/mach-omap2/board-omap3beagle.c > > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > > @@ -58,13 +58,25 @@ static struct omap_mmc_config > > omap3beagle_mmc_config __initdata = { > > }, > > }; > > > > +static struct platform_device omap3_beagle_twl4030rtc_device = { > > + .name = "twl4030_rtc", > > + .id = -1, > > +}; > > + > > static struct omap_board_config_kernel omap3_beagle_config[] > > __initdata = { > > { OMAP_TAG_UART, &omap3_beagle_uart_config }, > > { OMAP_TAG_MMC, &omap3beagle_mmc_config }, > > }; > > > > +static struct platform_device *omap3_beagle_devices[] __initdata = { > > +#ifdef CONFIG_RTC_DRV_TWL4030 > > + &omap3_beagle_twl4030rtc_device, > > +#endif > > +}; > > + > > static void __init omap3_beagle_init(void) > > { > > + platform_add_devices(omap3_beagle_devices, > > ARRAY_SIZE(omap3_beagle_devices)); > > omap_board_config = omap3_beagle_config; > > omap_board_config_size = ARRAY_SIZE(omap3_beagle_config); > > omap_serial_init(); > > - -- > > 1.5.4.3 > > > > > > -----BEGIN PGP SIGNATURE----- > > Version: GnuPG v1.4.5 (Darwin) > > > > iD8DBQFIIzK8MkyGM64RGpERAgE7AJ9meokVhJ/V/iR3PfwNbf0ZeR0aDACcDP2/ > > 2kdpcssXcbftzzC5o6D2mLU= > > =dk6K > > -----END PGP SIGNATURE----- > > -- > > To unsubscribe from this list: send the line "unsubscribe linux- > > omap" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: OMAP: add RTC support to beagleboard 2008-05-09 21:54 ` Tony Lindgren @ 2008-05-12 21:54 ` Koen Kooi 2008-05-12 22:34 ` Tony Lindgren 0 siblings, 1 reply; 8+ messages in thread From: Koen Kooi @ 2008-05-12 21:54 UTC (permalink / raw) To: Tony Lindgren; +Cc: linux-omap, Beagle Board -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Op 9 mei 2008, om 23:54 heeft Tony Lindgren het volgende geschreven: > * Koen Kooi <k.kooi@student.utwente.nl> [080509 07:56]: >> >> Op 8 mei 2008, om 19:04 heeft Koen Kooi het volgende geschreven: >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >>> >>> >>> Op 8 mei 2008, om 18:55 heeft andrzej zaborowski het volgende >>> geschreven: >>>> Something must be missing here, omap3_beagle_devices is not being >>>> referenced. >>>> >>>> The missing line probably looks something like >>>> platform_add_devices(omap3_beagle_devices, >>>> ARRAY_SIZE(omap3_beagle_devices)); >>> >>> You're 100% right :) I forgot --amend, so the patch missed my second >>> commit >>> >>>> You can also add the #ifdef around omap3_beagle_twl4030rtc_device >>>> to >>>> avoid a compiler warning, or drop it in both places. >>> >>> The idea is that a next patch (rudimentary lcd support) will add >>> device in there as well. I can move the ifdef for this patch if you >>> want. >>> >>> thanks for the review, >>> >>> Koen >>> >>> Updated patch: >> >> With the current patch I get this in the bootlog: >> >> usb0: RNDIS ready >> mice: PS/2 mouse device common for all mice >> twl4030_rtc twl4030_rtc: rtc core: registered twl4030_rtc as rtc0 >> OMAP Watchdog Timer Rev 0x31: initial timeout 60 sec >> [..] >> twl4030_rtc twl4030_rtc: setting system clock to 2000-01-01 00:02:15 >> UTC (946684935) >> >> So it works :) > > Pushing today. It still doesn't show up in git after the rc2 merge, did something go wrong? regards, Koen > > > Tony > >> >> regards, >> >> Koen >> >> >>> >>> >>> This patch adds RTC support to the omap3 based beagleboard >>> >>> Signed-off-by: Koen Kooi <koen@openembedded.org> >>> - --- >>> arch/arm/mach-omap2/board-omap3beagle.c | 12 ++++++++++++ >>> 1 files changed, 12 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/ >>> mach- >>> omap2/board-omap3beagle.c >>> index 626f004..0c0cbfc 100644 >>> - --- a/arch/arm/mach-omap2/board-omap3beagle.c >>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c >>> @@ -58,13 +58,25 @@ static struct omap_mmc_config >>> omap3beagle_mmc_config __initdata = { >>> }, >>> }; >>> >>> +static struct platform_device omap3_beagle_twl4030rtc_device = { >>> + .name = "twl4030_rtc", >>> + .id = -1, >>> +}; >>> + >>> static struct omap_board_config_kernel omap3_beagle_config[] >>> __initdata = { >>> { OMAP_TAG_UART, &omap3_beagle_uart_config }, >>> { OMAP_TAG_MMC, &omap3beagle_mmc_config }, >>> }; >>> >>> +static struct platform_device *omap3_beagle_devices[] __initdata >>> = { >>> +#ifdef CONFIG_RTC_DRV_TWL4030 >>> + &omap3_beagle_twl4030rtc_device, >>> +#endif >>> +}; >>> + >>> static void __init omap3_beagle_init(void) >>> { >>> + platform_add_devices(omap3_beagle_devices, >>> ARRAY_SIZE(omap3_beagle_devices)); >>> omap_board_config = omap3_beagle_config; >>> omap_board_config_size = ARRAY_SIZE(omap3_beagle_config); >>> omap_serial_init(); >>> - -- >>> 1.5.4.3 >>> >>> >>> -----BEGIN PGP SIGNATURE----- >>> Version: GnuPG v1.4.5 (Darwin) >>> >>> iD8DBQFIIzK8MkyGM64RGpERAgE7AJ9meokVhJ/V/iR3PfwNbf0ZeR0aDACcDP2/ >>> 2kdpcssXcbftzzC5o6D2mLU= >>> =dk6K >>> -----END PGP SIGNATURE----- >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux- >>> omap" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux- >> omap" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFIKLyDMkyGM64RGpERAt8CAJ4neeAxn9BooooblxlIJC4YVAB8xwCfX5WP 5onXr5l0Vm8IGwqtBWK4iEk= =TpiD -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: OMAP: add RTC support to beagleboard 2008-05-12 21:54 ` Koen Kooi @ 2008-05-12 22:34 ` Tony Lindgren 0 siblings, 0 replies; 8+ messages in thread From: Tony Lindgren @ 2008-05-12 22:34 UTC (permalink / raw) To: Koen Kooi; +Cc: linux-omap, Beagle Board * Koen Kooi <k.kooi@student.utwente.nl> [080512 14:55]: > > Op 9 mei 2008, om 23:54 heeft Tony Lindgren het volgende geschreven: > > * Koen Kooi <k.kooi@student.utwente.nl> [080509 07:56]: > >> > >> Op 8 mei 2008, om 19:04 heeft Koen Kooi het volgende geschreven: > >>> -----BEGIN PGP SIGNED MESSAGE----- > >>> Hash: SHA1 > >>> > >>> > >>> Op 8 mei 2008, om 18:55 heeft andrzej zaborowski het volgende > >>> geschreven: > >>>> Something must be missing here, omap3_beagle_devices is not being > >>>> referenced. > >>>> > >>>> The missing line probably looks something like > >>>> platform_add_devices(omap3_beagle_devices, > >>>> ARRAY_SIZE(omap3_beagle_devices)); > >>> > >>> You're 100% right :) I forgot --amend, so the patch missed my second > >>> commit > >>> > >>>> You can also add the #ifdef around omap3_beagle_twl4030rtc_device > >>>> to > >>>> avoid a compiler warning, or drop it in both places. > >>> > >>> The idea is that a next patch (rudimentary lcd support) will add > >>> device in there as well. I can move the ifdef for this patch if you > >>> want. > >>> > >>> thanks for the review, > >>> > >>> Koen > >>> > >>> Updated patch: > >> > >> With the current patch I get this in the bootlog: > >> > >> usb0: RNDIS ready > >> mice: PS/2 mouse device common for all mice > >> twl4030_rtc twl4030_rtc: rtc core: registered twl4030_rtc as rtc0 > >> OMAP Watchdog Timer Rev 0x31: initial timeout 60 sec > >> [..] > >> twl4030_rtc twl4030_rtc: setting system clock to 2000-01-01 00:02:15 > >> UTC (946684935) > >> > >> So it works :) > > > > Pushing today. > > It still doesn't show up in git after the rc2 merge, did something go > wrong? Hmm, sorry I guess I must have edited it manually because it did not apply. Then I probably forgot to commit it and moved onto other things and ran git-reset --hard... Can you please refresh and send it one more time? Thanks, Tony > > regards, > > Koen > > > > > > > > > Tony > > > >> > >> regards, > >> > >> Koen > >> > >> > >>> > >>> > >>> This patch adds RTC support to the omap3 based beagleboard > >>> > >>> Signed-off-by: Koen Kooi <koen@openembedded.org> > >>> - --- > >>> arch/arm/mach-omap2/board-omap3beagle.c | 12 ++++++++++++ > >>> 1 files changed, 12 insertions(+), 0 deletions(-) > >>> > >>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/ > >>> mach- > >>> omap2/board-omap3beagle.c > >>> index 626f004..0c0cbfc 100644 > >>> - --- a/arch/arm/mach-omap2/board-omap3beagle.c > >>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c > >>> @@ -58,13 +58,25 @@ static struct omap_mmc_config > >>> omap3beagle_mmc_config __initdata = { > >>> }, > >>> }; > >>> > >>> +static struct platform_device omap3_beagle_twl4030rtc_device = { > >>> + .name = "twl4030_rtc", > >>> + .id = -1, > >>> +}; > >>> + > >>> static struct omap_board_config_kernel omap3_beagle_config[] > >>> __initdata = { > >>> { OMAP_TAG_UART, &omap3_beagle_uart_config }, > >>> { OMAP_TAG_MMC, &omap3beagle_mmc_config }, > >>> }; > >>> > >>> +static struct platform_device *omap3_beagle_devices[] __initdata > >>> = { > >>> +#ifdef CONFIG_RTC_DRV_TWL4030 > >>> + &omap3_beagle_twl4030rtc_device, > >>> +#endif > >>> +}; > >>> + > >>> static void __init omap3_beagle_init(void) > >>> { > >>> + platform_add_devices(omap3_beagle_devices, > >>> ARRAY_SIZE(omap3_beagle_devices)); > >>> omap_board_config = omap3_beagle_config; > >>> omap_board_config_size = ARRAY_SIZE(omap3_beagle_config); > >>> omap_serial_init(); > >>> - -- > >>> 1.5.4.3 > >>> > >>> > >>> -----BEGIN PGP SIGNATURE----- > >>> Version: GnuPG v1.4.5 (Darwin) > >>> > >>> iD8DBQFIIzK8MkyGM64RGpERAgE7AJ9meokVhJ/V/iR3PfwNbf0ZeR0aDACcDP2/ > >>> 2kdpcssXcbftzzC5o6D2mLU= > >>> =dk6K > >>> -----END PGP SIGNATURE----- > >>> -- > >>> To unsubscribe from this list: send the line "unsubscribe linux- > >>> omap" in > >>> the body of a message to majordomo@vger.kernel.org > >>> More majordomo info at http://vger.kernel.org/majordomo-info.html > >>> > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux- > >> omap" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-05-12 22:34 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-05-08 16:35 [PATCH] ARM: OMAP: add RTC support to beagleboard Koen Kooi 2008-05-08 16:53 ` Steve Sakoman 2008-05-08 16:55 ` andrzej zaborowski 2008-05-08 17:04 ` Koen Kooi 2008-05-09 14:49 ` Koen Kooi 2008-05-09 21:54 ` Tony Lindgren 2008-05-12 21:54 ` Koen Kooi 2008-05-12 22:34 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox