From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: pending patch Date: Fri, 9 May 2008 14:55:15 -0700 Message-ID: <20080509215515.GG5976@atomide.com> References: <20080425075245.GX23350@gandalf.research.nokia.com> <200804250235.21910.david-b@pacbell.net> <20080425101837.GZ23350@gandalf.research.nokia.com> <20080425163644.GC23025@atomide.com> <20080425184543.GB27479@kedavra.cpe.vivax.com.br> <20080509091919.GB4326@gandalf.research.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-bos.mailhop.org ([63.208.196.179]:57293 "EHLO mho-02-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbYEIVzV (ORCPT ); Fri, 9 May 2008 17:55:21 -0400 Content-Disposition: inline In-Reply-To: <20080509091919.GB4326@gandalf.research.nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: ext Felipe Balbi , ext David Brownell , linux-omap@vger.kernel.org * Felipe Balbi [080509 02:20]: > On Fri, Apr 25, 2008 at 09:45:43PM +0300, ext Felipe Balbi wrote: > > On Fri, Apr 25, 2008 at 09:36:44AM -0700, Tony Lindgren wrote: > > > * Felipe Balbi [080425 03:19]: > > > > On Fri, Apr 25, 2008 at 02:35:21AM -0700, David Brownell wrote: > > > > > On Friday 25 April 2008, Felipe Balbi wrote: > > > > > > Hi Tony and Dave, > > > > > > > > > > > > there's this one pending patch [1]. Do you guys have any comments on that > > > > > > one? > > > > > > > > > > > > Author: Felipe Balbi > > > > > > Date: Thu Apr 17 17:34:20 2008 +0300 > > > > > > > > > > > > USB: MUSB: Don't ignore disconnect on suspend > > > > > > > > > > > > As soon as a usb device is disconnect we should > > > > > > fall into a_wait_bcon state, ignoring disconnect > > > > > > irq will prevent this behaviour. > > > > > > > > > > If it passes the OTG tests, fine. I don't recall how the > > > > > HNP handoff's disconnect signaling is handled ... presumably > > > > > it's different from some "real" disconnect. > > > > > > > > No opt available for now... > > > > The problem is that when you ignore disconnect on suspend you only ack > > > > the disconnect interrupt after attaching other device. It won't get us > > > > too much trouble besides the bit will still set in int_src, but still > > > > musb should ack disconnect as soon as it happens, shouldn't it? And > > > > right after that start the timer for switching from a_wait_bcon to > > > > a_wait_vfall and after that a_idle. > > > > > > > > But as soon as I have and opt available, I'll try to run this test and > > > > report you if I can see any issues with this patch applied. > > > > > > > > For now, let's keep it as pending so. > > > > > > Yeah. I have not applied any musb/tusb patches because of being afraid > > > of the HS OTG OPT tests breaking.. Still have them all in my l-o mailbox > > > though. So let's plan on applying things after somebody (Felipe?) gets > > > to run HS OTG OPT on them for musb and tusb. > > Ok, this patch doesn't break any opt tests. Safe to apply. Tested > yesterday. Pushing. Tony