From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: Dirk Behme <dirk.behme@googlemail.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH v3] ARM: OMAP3: Check for L2 cache enabled
Date: Wed, 14 May 2008 16:06:46 -0700 [thread overview]
Message-ID: <20080514230644.GH8928@atomide.com> (raw)
In-Reply-To: <20080511084423.GA9164@kedavra.cpe.vivax.com.br>
* Felipe Balbi <me@felipebalbi.com> [080511 01:43]:
> On Sun, May 11, 2008 at 08:12:48AM +0200, Dirk Behme wrote:
> >
> > Enabling L2 cache of Cortex-A8 based OMAP3 has to be done by bootloader.
> > Check if this is done and warn if not.
> >
> > Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
> Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
Pushing today.
Tony
> >
> > ----
> >
> > Changes in v3: Remove braces. Thanks to Felipe for review!
>
> > Index: linux-beagle/arch/arm/mach-omap2/id.c
> > ===================================================================
> > --- linux-beagle.orig/arch/arm/mach-omap2/id.c
> > +++ linux-beagle/arch/arm/mach-omap2/id.c
> > @@ -267,3 +267,25 @@ void __init omap2_check_revision(void)
> >
> > }
> >
> > +#ifdef CONFIG_ARCH_OMAP3
> > +/*
> > + * OMAP3 has L2 cache which has to be enabled by bootloader.
> > + */
> > +static int __init omap3_check_l2cache(void)
> > +{
> > + u32 val;
> > +
> > + /* Get CP15 AUX register, bit 1 enabled indicates L2 cache is on */
> > + asm volatile("mrc p15, 0, %0, c1, c0, 1":"=r" (val));
> > +
> > + if ((val & 0x2) == 0)
> > + printk(KERN_WARNING "Warning: L2 cache not enabled. Check "
> > + "your bootloader. L2 off results in performance loss\n");
> > + else
> > + pr_info("OMAP3 L2 cache enabled\n");
> > +
> > + return 0;
> > +}
> > +
> > +arch_initcall(omap3_check_l2cache);
> > +#endif /* CONFIG_ARCH_OMAP3 */
>
>
> --
> Best Regards,
>
> Felipe Balbi
> me@felipebalbi.com
> http://blog.felipebalbi.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-05-14 23:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 6:12 [PATCH v3] ARM: OMAP3: Check for L2 cache enabled Dirk Behme
2008-05-11 8:44 ` Felipe Balbi
2008-05-14 23:06 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514230644.GH8928@atomide.com \
--to=tony@atomide.com \
--cc=dirk.behme@googlemail.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox