From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org, "Jouni Högander" <jouni.hogander@nokia.com>
Subject: Re: [PATCH] ARCH: OMAP: MUSB: Do not block sleep
Date: Wed, 14 May 2008 16:12:49 -0700 [thread overview]
Message-ID: <20080514231248.GI8928@atomide.com> (raw)
In-Reply-To: <1210805485-2645-1-git-send-email-felipe.balbi@nokia.com>
* Felipe Balbi <felipe.balbi@nokia.com> [080514 16:06]:
> Do not block sleep while musb clock is enabled
> as it completely blocks dynamic sleep.
Hmm, as far as I remember this will break all USB connections at least
on tusb if osc_ck is taken out. Can you check that?
Tony
>
> Thanks to Jouni Högander.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> Signed-off-by: Jouni Högander <jouni.hogander@nokia.com>
> ---
> arch/arm/mach-omap2/usb-musb.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index cbd59f8..bd3556b 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -58,7 +58,6 @@ static int musb_set_clock(struct clk *clk, int state)
> if (clk_on > 0)
> return -ENODEV;
>
> - omap2_block_sleep();
> clk_enable(clk);
> clk_on = 1;
> } else {
> @@ -67,7 +66,6 @@ static int musb_set_clock(struct clk *clk, int state)
>
> clk_disable(clk);
> clk_on = 0;
> - omap2_allow_sleep();
> }
>
> return 0;
> --
> 1.5.4.3.447.gc95b3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-05-14 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 22:51 [PATCH] ARCH: OMAP: MUSB: Do not block sleep Felipe Balbi
2008-05-14 23:12 ` Tony Lindgren [this message]
2008-05-15 7:58 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514231248.GI8928@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=jouni.hogander@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox