From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] Input: Make lm8323 sticky key to work with console Date: Thu, 15 May 2008 01:31:44 -0700 Message-ID: <20080515083144.GN8928@atomide.com> References: <1210824079-22548-1-git-send-email-tony@atomide.com> <1210824079-22548-2-git-send-email-tony@atomide.com> <1210824079-22548-3-git-send-email-tony@atomide.com> <20080515080333.GD4625@kedavra.cpe.vivax.com.br> <20080515082013.GB4853@kedavra.cpe.vivax.com.br> <20080515082957.GM8928@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:49617 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbYEOIbp (ORCPT ); Thu, 15 May 2008 04:31:45 -0400 Content-Disposition: inline In-Reply-To: <20080515082957.GM8928@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: andrzej zaborowski , linux-omap@vger.kernel.org, daniel.stone@nokia.com * Tony Lindgren [080515 01:30]: > * Felipe Balbi [080515 01:19]: > > On Thu, May 15, 2008 at 10:14:24AM +0200, andrzej zaborowski wrote: > > > On 15/05/2008, Felipe Balbi wrote: > > > > On Wed, May 14, 2008 at 09:01:19PM -0700, Tony Lindgren wrote: > > > > > This allows using N810 keyboard from console by adding optional > > > > > Fn and shift sticky key handling by passing them from platform_data. > > > > > > > > > > Currently some not so obvious mappings are: > > > > > > > > > > - Pipe is Fn + Enter > > > > > - Delete is Fn + Backspace > > > > > - Escape is Fn + Ctrl > > > > > > > > no tab? :-( > > > > > > > > Fn + space maybe?? :-p > > > > > > Fn + Right is assigned in the patch (I check too :) ). But I'm not > > > sure whther that should be done in the lm8323 driver or elsewhere. The > > > existence of keys like Fn and Shift is N810-specific and lm8323 is > > > just a gpio matrix keypad chip. > > > > but that's coming from board file. It should be ok. > > Yeah I think it should be OK too as nothing happens if platform_data does > not pass fn or shift keys. So the driver should work with any keyboard > layout. BTW, I like the idea for FN + space for tab key, easier to use than FN + Right :) Tony