From: Daniel Stone <daniel.stone@nokia.com>
To: ext Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/2] Make N810 keyboard work with console
Date: Thu, 15 May 2008 11:58:52 +0300 [thread overview]
Message-ID: <20080515085852.GF12699@intune.research.nokia.com> (raw)
In-Reply-To: <1210824079-22548-1-git-send-email-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
On Wed, May 14, 2008 at 09:01:17PM -0700, ext Tony Lindgren wrote:
> Here are few fun patches for N810 hackers to make the integrated
> keyboard work with console :) This should be done in a generic way
> and the old behaviour is preserved if optional sticky keys are not
> passed from platform_data.
Uhm. If you're going to implement latching/locking keys, surely it'd be
better to do this in the generic input layer than the keyboard driver?
NAK from myself (for what little that means) simply due to the sheer
horror of seeing what should, by all rights, be a tiny driver, explode
into non-triviality. :)
Cheers,
Daniel
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-05-15 8:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 4:01 [PATCH 0/2] Make N810 keyboard work with console Tony Lindgren
2008-05-15 4:01 ` [PATCH 1/2] Input: Fix lm8323 probe and module unloading Tony Lindgren
2008-05-15 4:01 ` [PATCH 2/2] Input: Make lm8323 sticky key to work with console Tony Lindgren
2008-05-15 8:03 ` Felipe Balbi
2008-05-15 8:14 ` andrzej zaborowski
2008-05-15 8:20 ` Felipe Balbi
2008-05-15 8:29 ` Tony Lindgren
2008-05-15 8:31 ` Tony Lindgren
2008-05-15 8:01 ` [PATCH 1/2] Input: Fix lm8323 probe and module unloading Felipe Balbi
2008-05-15 18:18 ` [PATCH 1/2] Input: Fix lm8323 probe and module unloading, take #2 Tony Lindgren
2008-05-15 22:54 ` Tony Lindgren
2008-05-15 8:58 ` Daniel Stone [this message]
2008-05-15 17:22 ` [PATCH 0/2] Make N810 keyboard work with console Tony Lindgren
2008-05-15 18:19 ` [PATCH 0/2] Make N810 keyboard work with console, take #2 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515085852.GF12699@intune.research.nokia.com \
--to=daniel.stone@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox