Re: [PATCH 0/2] Make N810 keyboard work with console

[Tony Lindgren <tony@atomide.com>]

* Daniel Stone <daniel.stone@nokia.com> [080515 01:57]:
> On Wed, May 14, 2008 at 09:01:17PM -0700, ext Tony Lindgren wrote:
> > Here are few fun patches for N810 hackers to make the integrated
> > keyboard work with console :) This should be done in a generic way
> > and the old behaviour is preserved if optional sticky keys are not
> > passed from platform_data.
> 
> Uhm.  If you're going to implement latching/locking keys, surely it'd be
> better to do this in the generic input layer than the keyboard driver?

Yeah I agree it would be best to have the sticky keys handled in the
input layer in generic way in the long run. Doing it in a generic ways
would just require passing the flags with selected keys to input layer.

> NAK from myself (for what little that means) simply due to the sheer
> horror of seeing what should, by all rights, be a tiny driver, explode
> into non-triviality. :)

Well I'll take a look at some point how to move the is_sticky handling
to input layer. Meanwhile people can use this patch to have something
usable.

Tony