From: David Brownell <david-b@pacbell.net>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, felipe.balbi@nokia.com
Subject: Re: [PATCH 1/5] CF: Change omap_cf.c to use omap_readw/writew instead of __REG for multi-omap
Date: Fri, 16 May 2008 14:26:17 -0700 [thread overview]
Message-ID: <200805161426.18409.david-b@pacbell.net> (raw)
In-Reply-To: <1210972076-23911-2-git-send-email-tony@atomide.com>
On Friday 16 May 2008, Tony Lindgren wrote:
> @@ -38,19 +38,19 @@
> #define CF_BASE 0xfffe2800
>
> /* status; read after IRQ */
> -#define CF_STATUS_REG __REG16(CF_BASE + 0x00)
> +#define CF_STATUS (CF_BASE + 0x00)
> # define CF_STATUS_BAD_READ (1 << 2)
> # define CF_STATUS_BAD_WRITE (1 << 1)
> # define CF_STATUS_CARD_DETECT (1 << 0)
>
> /* which chipselect (CS0..CS3) is used for CF (active low) */
> -#define CF_CFG_REG __REG16(CF_BASE + 0x02)
> +#define CF_CFG (CF_BASE + 0x02)
>
> ...
Trying to understand the plan here. This first patches
are to remove __REG*() access, we hillater patches will
be needed to convert things to omap_readl(BASE + OFFSET)
style accessors? (BASE being SOC-specific, and passed
down from system init code.)
Not that CF is a good example of that. I don't think
it exists on current chips. ;)
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-05-16 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 21:07 [PATCH 0/5] Remove __REG macro access for multi-omap Tony Lindgren
2008-05-16 21:07 ` [PATCH 1/5] CF: Change omap_cf.c to use omap_readw/writew instead of __REG " Tony Lindgren
2008-05-16 21:07 ` [PATCH 2/5] USB: Change omap USB code to use omap_read/write " Tony Lindgren
2008-05-16 21:07 ` [PATCH 3/5] ARM: OMAP: Change __REG access to omap/read write for traffic controller Tony Lindgren
2008-05-16 21:07 ` [PATCH 4/5] musb_hdrc: Change __REG access to omap_read/write for multi-boot Tony Lindgren
2008-05-16 21:07 ` [PATCH 5/5] ARM: OMAP: Remove __REG access for multi-omap Tony Lindgren
2008-05-17 10:19 ` [PATCH 2/5] USB: Change omap USB code to use omap_read/write instead of __REG " Felipe Balbi
2008-05-16 21:26 ` David Brownell [this message]
2008-05-16 21:49 ` [PATCH 1/5] CF: Change omap_cf.c to use omap_readw/writew " Tony Lindgren
2008-05-28 0:51 ` [PATCH] Misc fixes to this series (CF: Change omap_cf.c to use omap_readw/writew instead of __REG for multi-omap) Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805161426.18409.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox