From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [RFC PATCH 3/5] USB: MUSB: Do not turn vbus on immediately
Date: Fri, 16 May 2008 10:39:22 -0700 [thread overview]
Message-ID: <20080516173922.GL23002@atomide.com> (raw)
In-Reply-To: <1210681796-1984-4-git-send-email-felipe.balbi@nokia.com>
* Felipe Balbi <felipe.balbi@nokia.com> [080513 05:35]:
> From: ext Felipe Balbi <felipe.balbi@nokia.com>
>
> Wait for user interaction to turn vbus on.
> On end user products, this behavior could be
> masked under some application with permission to
> write to /sys/devices/platform/musb_hdrc/session.
Again, this breaks USB host support for basic USB devices.
Tony
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> drivers/usb/musb/tusb6010.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/musb/tusb6010.c b/drivers/usb/musb/tusb6010.c
> index 9f92cef..14220d9 100644
> --- a/drivers/usb/musb/tusb6010.c
> +++ b/drivers/usb/musb/tusb6010.c
> @@ -675,11 +675,6 @@ tusb_otg_ints(struct musb *musb, u32 int_src, void __iomem *tbase)
> musb->xceiv.default_a = default_a;
> musb->xceiv.state = default_a ? OTG_STATE_A_IDLE
> : OTG_STATE_B_IDLE;
> - tusb_source_power(musb, default_a);
> -
> - /* Don't allow idling immediately */
> - if (default_a)
> - idle_timeout = jiffies + (HZ * 3);
> }
>
> /* VBUS state change */
> --
> 1.5.5.1.125.gc697a
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-05-16 17:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 12:29 [RFC PATCH 0/5] musb changes Felipe Balbi
2008-05-13 12:29 ` [RFC PATCH 1/5] USB: MUSB: Switch to a_idle when micro/mini-a cable is attached Felipe Balbi
2008-05-13 12:29 ` [RFC PATCH 2/5] USB: MUSB: Change srp sysfs entry to session Felipe Balbi
2008-05-13 12:29 ` [RFC PATCH 3/5] USB: MUSB: Do not turn vbus on immediately Felipe Balbi
2008-05-13 12:29 ` [RFC PATCH 4/5] USB: MUSB: Always allow musb to idle Felipe Balbi
2008-05-13 12:29 ` [RFC PATCH 5/5] USB: MUSB: We already know the default timeout Felipe Balbi
2008-05-16 17:39 ` Tony Lindgren [this message]
2008-05-16 17:38 ` [RFC PATCH 1/5] USB: MUSB: Switch to a_idle when micro/mini-a cable is attached Tony Lindgren
2008-05-16 18:33 ` Felipe Balbi
2008-05-16 18:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516173922.GL23002@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox