From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] clock34xx.c: fix spinlock reentry in omap3_noncore_dpll_enable()
Date: Fri, 16 May 2008 10:49:59 -0700 [thread overview]
Message-ID: <20080516174958.GR23002@atomide.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0805151445220.29298@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [080515 13:50]:
>
> omap3_noncore_dpll_enable() calls clk_get_rate(), which causes an attempt
> to re-enter the clockfw_lock spinlock. Fix by calling
> omap2_get_dpll_rate() instead.
Pushing.
Tony
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> ---
>
> arch/arm/mach-omap2/clock34xx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/arch/arm/mach-omap2/clock34xx.c b/arch/arm/mach-omap2/clock34xx.c
> index 670c945..71357db 100644
> --- a/arch/arm/mach-omap2/clock34xx.c
> +++ b/arch/arm/mach-omap2/clock34xx.c
> @@ -273,7 +273,7 @@ static int omap3_noncore_dpll_enable(struct clk *clk)
> if (clk == &dpll3_ck)
> return -EINVAL;
>
> - if (clk->parent->rate == clk_get_rate(clk))
> + if (clk->parent->rate == omap2_get_dpll_rate(clk))
> r = _omap3_noncore_dpll_bypass(clk);
> else
> r = _omap3_noncore_dpll_lock(clk);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-05-16 17:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 20:48 [PATCH] clock34xx.c: fix spinlock reentry in omap3_noncore_dpll_enable() Paul Walmsley
2008-05-16 17:49 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516174958.GR23002@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox