public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: linux-omap@vger.kernel.org
Cc: Toshihiro Kobayashi <toshihiro.kobayashi@nokia.com>
Subject: [PATCH 6/6] DSP Gateway: remove manual clockdomain/powerdomain tweaking
Date: Tue, 20 May 2008 18:43:00 -0600	[thread overview]
Message-ID: <20080521004152.6131.45906.stgit@localhost.localdomain> (raw)
In-Reply-To: <20080521003910.6131.63409.stgit@localhost.localdomain>

The recent powerdomain and clockdomain layer updates for OMAP24XX should
now control the DSP powerdomain and clockdomain automatically when
DSP Gateway calls clk_{enable,disable}().  Remove the manual
clockdomain/powerdomain register tweaks from DSP Gateway.


Signed-off-by: Paul Walmsley <paul@pwsan.com>
---

 drivers/dsp/dspgateway/dsp_core.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/drivers/dsp/dspgateway/dsp_core.c b/drivers/dsp/dspgateway/dsp_core.c
index 913376e..68cc9e6 100644
--- a/drivers/dsp/dspgateway/dsp_core.c
+++ b/drivers/dsp/dspgateway/dsp_core.c
@@ -460,16 +460,6 @@ static inline void dsp_clk_disable(void) {}
 #elif defined(CONFIG_ARCH_OMAP2)
 static inline void dsp_clk_enable(void)
 {
-	/*XXX should be handled in mach-omap[1,2] XXX*/
-	prm_write_mod_reg(OMAP24XX_FORCESTATE | (1 << OMAP_POWERSTATE_SHIFT),
-			  OMAP24XX_DSP_MOD, PM_PWSTCTRL);
-
-	cm_set_mod_reg_bits(OMAP2420_AUTO_DSP_IPI, OMAP24XX_DSP_MOD,
-			    CM_AUTOIDLE);
-
-	cm_set_mod_reg_bits(OMAP24XX_AUTOSTATE_DSP_MASK, OMAP24XX_DSP_MOD,
-			    CM_CLKSTCTRL);
-
 	clk_enable(dsp_fck_handle);
 	clk_enable(dsp_ick_handle);
 	__dsp_per_enable();
@@ -479,9 +469,6 @@ static inline void dsp_clk_disable(void)
 	__dsp_per_disable();
 	clk_disable(dsp_ick_handle);
 	clk_disable(dsp_fck_handle);
-
-	prm_write_mod_reg(OMAP24XX_FORCESTATE | (3 << OMAP_POWERSTATE_SHIFT),
-			  OMAP24XX_DSP_MOD, PM_PWSTCTRL);
 }
 #endif
 



  parent reply	other threads:[~2008-05-21  0:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21  0:41 [PATCH 0/6] OMAP2 PM: link clocks to clockdomains, use clkdm/pwrdm code Paul Walmsley
2008-05-21  0:41 ` [PATCH 1/6] 24xx clock: associate clocks with clockdomains Paul Walmsley
2008-05-21  0:41 ` [PATCH 2/6] 24xx clock: add missing SSI L4 interface clock Paul Walmsley
2008-05-21  0:41 ` [PATCH 3/6] powerdomain: add pwrdm_get_mem_bank_count() Paul Walmsley
2008-05-21  0:41 ` [PATCH 4/6] clockdomain: add clkdm_get_pwrdm() Paul Walmsley
2008-05-21  0:41 ` [PATCH 5/6] 24xx PM: convert pm24xx.c code to use pwrdm/clkdm interfaces Paul Walmsley
2008-05-21  0:43 ` Paul Walmsley [this message]
2008-05-28 20:41 ` [PATCH 0/6] OMAP2 PM: link clocks to clockdomains, use clkdm/pwrdm code Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521004152.6131.45906.stgit@localhost.localdomain \
    --to=paul@pwsan.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=toshihiro.kobayashi@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox