Re: [PATCH 5/5] MACH-OMAP2: MCBSP: Add support for mcbsp on mach-omap2

[Tony Lindgren <tony@atomide.com>]

* Gadiyar, Anand <gadiyar@ti.com> [080529 09:18]:
> > +
> > +static struct omap_mcbsp_platform_data omap2_mcbsp_pdata[] = {
> > +#ifdef CONFIG_ARCH_OMAP24XX
> > +       {
> > +               .virt_base      = IO_ADDRESS(OMAP24XX_MCBSP1_BASE),
> > +               .dma_rx_sync    = OMAP24XX_DMA_MCBSP1_RX,
> > +               .dma_tx_sync    = OMAP24XX_DMA_MCBSP1_TX,
> > +               .rx_irq         = INT_24XX_MCBSP1_IRQ_RX,
> > +               .tx_irq         = INT_24XX_MCBSP1_IRQ_TX,
> > +               .ops            = &omap2_mcbsp_ops,
> > +               .clk_name       = "mcbsp_clk",
> > +       },
> > +       {
> > +               .virt_base      = IO_ADDRESS(OMAP24XX_MCBSP2_BASE),
> > +               .dma_rx_sync    = OMAP24XX_DMA_MCBSP2_RX,
> > +               .dma_tx_sync    = OMAP24XX_DMA_MCBSP2_TX,
> > +               .rx_irq         = INT_24XX_MCBSP2_IRQ_RX,
> > +               .tx_irq         = INT_24XX_MCBSP2_IRQ_TX,
> > +               .ops            = &omap2_mcbsp_ops,
> > +               .clk_name       = "mcbsp_clk",
> > +       },
> > +#endif
> > +#ifdef CONFIG_ARCH_OMAP34XX
> > +       {
> > +               .virt_base      = IO_ADDRESS(OMAP34XX_MCBSP1_BASE),
> > +               .dma_rx_sync    = OMAP24XX_DMA_MCBSP1_RX,
> > +               .dma_tx_sync    = OMAP24XX_DMA_MCBSP1_TX,
> > +               .rx_irq         = INT_24XX_MCBSP1_IRQ_RX,
> > +               .tx_irq         = INT_24XX_MCBSP1_IRQ_TX,
> > +               .ops            = &omap2_mcbsp_ops,
> > +               .clk_name       = "mcbsp_clk",
> > +       },
> > +       {
> > +               .virt_base      = IO_ADDRESS(OMAP34XX_MCBSP2_BASE),
> > +               .dma_rx_sync    = OMAP24XX_DMA_MCBSP2_RX,
> > +               .dma_tx_sync    = OMAP24XX_DMA_MCBSP2_TX,
> > +               .rx_irq         = INT_24XX_MCBSP2_IRQ_RX,
> > +               .tx_irq         = INT_24XX_MCBSP2_IRQ_TX,
> > +               .ops            = &omap2_mcbsp_ops,
> > +               .clk_name       = "mcbsp_clk",
> > +       },
> > +#endif
> > +};
> 
> I guess Tony won't like this as it will break support for multi-omap.

Well looks like they both can be compiled in, so it should be fine :)
That is assuming 242x and 243x have same OMAP2XX_MCBSP[12]_BASE.

And IO_ADDRESS will eventually be OMAP2_IO_ADDRESS, which is same
for 24xx and 34xx.

Regards,

Tony