* [PATCH] PRCM: OMAP3: Fix to wrongly modified omap2_clk_wait_ready
@ 2008-06-09 9:32 Jouni Hogander
2008-06-10 0:11 ` Paul Walmsley
0 siblings, 1 reply; 3+ messages in thread
From: Jouni Hogander @ 2008-06-09 9:32 UTC (permalink / raw)
To: linux-omap, tony
omap2_clk_wait_ready was wrongly modified to check
registers contents. This fix changes it back to check
addresses.
Signed-off-by: Jouni Hogander <jouni.hogander@nokia.com>
---
arch/arm/mach-omap2/clock.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index d3ab537..ed15868 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -246,8 +246,8 @@ static void omap2_clk_wait_ready(struct clk *clk)
/* REVISIT: What are the appropriate exclusions for 34XX? */
/* OMAP3: ignore DSS-mod clocks */
if (cpu_is_omap34xx() &&
- ((reg & ~0xff) == cm_read_mod_reg(OMAP3430_DSS_MOD, 0) ||
- (((reg & ~0xff) == cm_read_mod_reg(CORE_MOD, 0)) &&
+ ((reg & ~0xff) == (__force u32)OMAP34XX_CM_REGADDR(OMAP3430_DSS_MOD, 0) ||
+ (((reg & ~0xff) == (__force u32)OMAP34XX_CM_REGADDR(CORE_MOD, 0)) &&
clk->enable_bit == OMAP3430_EN_SSI_SHIFT)))
return;
--
1.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PRCM: OMAP3: Fix to wrongly modified omap2_clk_wait_ready
2008-06-09 9:32 [PATCH] PRCM: OMAP3: Fix to wrongly modified omap2_clk_wait_ready Jouni Hogander
@ 2008-06-10 0:11 ` Paul Walmsley
2008-06-10 19:01 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Paul Walmsley @ 2008-06-10 0:11 UTC (permalink / raw)
To: Jouni Hogander; +Cc: linux-omap, tony
On Mon, 9 Jun 2008, Jouni Hogander wrote:
> omap2_clk_wait_ready was wrongly modified to check
> registers contents. This fix changes it back to check
> addresses.
>
> Signed-off-by: Jouni Hogander <jouni.hogander@nokia.com>
Acked-by: Paul Walmsley <paul@pwsan.com>
- Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PRCM: OMAP3: Fix to wrongly modified omap2_clk_wait_ready
2008-06-10 0:11 ` Paul Walmsley
@ 2008-06-10 19:01 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2008-06-10 19:01 UTC (permalink / raw)
To: Paul Walmsley; +Cc: Jouni Hogander, linux-omap
* Paul Walmsley <paul@pwsan.com> [080609 17:11]:
> On Mon, 9 Jun 2008, Jouni Hogander wrote:
>
> > omap2_clk_wait_ready was wrongly modified to check
> > registers contents. This fix changes it back to check
> > addresses.
> >
> > Signed-off-by: Jouni Hogander <jouni.hogander@nokia.com>
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
Pushing today.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-10 19:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-09 9:32 [PATCH] PRCM: OMAP3: Fix to wrongly modified omap2_clk_wait_ready Jouni Hogander
2008-06-10 0:11 ` Paul Walmsley
2008-06-10 19:01 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox