[PATCH] This patch fixes "scheduling while atomic" bug when driver is unloaded.

[PATCH] This patch fixes "scheduling while atomic" bug when driver is unloaded.

[Roman Tereshonkov]

Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
---
 drivers/input/touchscreen/tsc2005.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/tsc2005.c b/drivers/input/touchscreen/tsc2005.c
index fa01799..408caf0 100644
--- a/drivers/input/touchscreen/tsc2005.c
+++ b/drivers/input/touchscreen/tsc2005.c
@@ -661,11 +661,10 @@ err1:
 static int __devexit tsc2005_remove(struct spi_device *spi)
 {
 	struct tsc2005 *ts = dev_get_drvdata(&spi->dev);
-	unsigned long flags;
 
-	spin_lock_irqsave(&ts->lock, flags);
+	mutex_lock(&ts->mutex);
 	tsc2005_disable(ts);
-	spin_unlock_irqrestore(&ts->lock, flags);
+	mutex_unlock(&ts->mutex);
 
 	device_remove_file(&ts->spi->dev, &dev_attr_disable_ts);
 	device_remove_file(&ts->spi->dev, &dev_attr_pen_down);
-- 
1.5.5.1

Re: [PATCH] This patch fixes "scheduling while atomic" bug when driver is unloaded.

[Felipe Balbi]

On Tue, Jun 10, 2008 at 03:16:36PM +0300, Tereshonkov Roman wrote:
> 
> Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>

tsc2005_disable() sleeps.

Acked-by: Felipe Balbi <felipe.balbi@nokia.com>

> ---
>  drivers/input/touchscreen/tsc2005.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/tsc2005.c b/drivers/input/touchscreen/tsc2005.c
> index fa01799..408caf0 100644
> --- a/drivers/input/touchscreen/tsc2005.c
> +++ b/drivers/input/touchscreen/tsc2005.c
> @@ -661,11 +661,10 @@ err1:
>  static int __devexit tsc2005_remove(struct spi_device *spi)
>  {
>  	struct tsc2005 *ts = dev_get_drvdata(&spi->dev);
> -	unsigned long flags;
>  
> -	spin_lock_irqsave(&ts->lock, flags);
> +	mutex_lock(&ts->mutex);
>  	tsc2005_disable(ts);
> -	spin_unlock_irqrestore(&ts->lock, flags);
> +	mutex_unlock(&ts->mutex);
>  
>  	device_remove_file(&ts->spi->dev, &dev_attr_disable_ts);
>  	device_remove_file(&ts->spi->dev, &dev_attr_pen_down);
> -- 
> 1.5.5.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Best Regards,

Felipe Balbi
me@felipebalbi.com
http://blog.felipebalbi.com

Re: [PATCH] This patch fixes "scheduling while atomic" bug when driver is unloaded.

[Tony Lindgren]

* Felipe Balbi <me@felipebalbi.com> [080610 12:05]:
> On Tue, Jun 10, 2008 at 03:16:36PM +0300, Tereshonkov Roman wrote:
> > 
> > Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
> 
> tsc2005_disable() sleeps.
> 
> Acked-by: Felipe Balbi <felipe.balbi@nokia.com>

Pushing today.

Tony


> > ---
> >  drivers/input/touchscreen/tsc2005.c |    5 ++---
> >  1 files changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/input/touchscreen/tsc2005.c b/drivers/input/touchscreen/tsc2005.c
> > index fa01799..408caf0 100644
> > --- a/drivers/input/touchscreen/tsc2005.c
> > +++ b/drivers/input/touchscreen/tsc2005.c
> > @@ -661,11 +661,10 @@ err1:
> >  static int __devexit tsc2005_remove(struct spi_device *spi)
> >  {
> >  	struct tsc2005 *ts = dev_get_drvdata(&spi->dev);
> > -	unsigned long flags;
> >  
> > -	spin_lock_irqsave(&ts->lock, flags);
> > +	mutex_lock(&ts->mutex);
> >  	tsc2005_disable(ts);
> > -	spin_unlock_irqrestore(&ts->lock, flags);
> > +	mutex_unlock(&ts->mutex);
> >  
> >  	device_remove_file(&ts->spi->dev, &dev_attr_disable_ts);
> >  	device_remove_file(&ts->spi->dev, &dev_attr_pen_down);
> > -- 
> > 1.5.5.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> -- 
> Best Regards,
> 
> Felipe Balbi
> me@felipebalbi.com
> http://blog.felipebalbi.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html