public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [Resend][PATCH] Fix for the i2c initialization error on 2430sdp
@ 2008-06-09  6:25 arun c
  2008-06-09 12:53 ` Eduardo Valentin
  0 siblings, 1 reply; 3+ messages in thread
From: arun c @ 2008-06-09  6:25 UTC (permalink / raw)
  To: linux-omap; +Cc: Chandra shekhar, Felipe Balbi, Eduardo Valentin

Hi all,

Resending the patch after incorporating comments from
Chandra , Eduardo Valentin and Felipe.

########################################################


>From ee2a6fd572c6d0464166fc8123982a38b36e7776 Mon Sep 17 00:00:00 2001
From: arun <arunedarath@mistralsolutions.com>
Date: Fri, 6 Jun 2008 18:18:50 +0530
Subject: [PATCH] Fix for the i2c initialization error on 2430sdp


Signed-off-by: arun <arunedarath@mistralsolutions.com>
---
 arch/arm/mach-omap2/board-2430sdp.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-2430sdp.c
b/arch/arm/mach-omap2/board-2430sdp.c
index e078a2a..780913e 100644
--- a/arch/arm/mach-omap2/board-2430sdp.c
+++ b/arch/arm/mach-omap2/board-2430sdp.c
@@ -379,8 +379,12 @@ static struct omap_board_config_kernel
sdp2430_config[] __initdata = {

 static int __init omap2430_i2c_init(void)
 {
-	omap_register_i2c_bus(1, 400, NULL, 0);
+	/*
+	 * Registering bus 2 first to avoid twl4030 misbehaving as 2430SDP
+	 * has twl4030 on bus 2
+	 */
 	omap_register_i2c_bus(2, 2600, NULL, 0);
+	omap_register_i2c_bus(1, 400, NULL, 0);
 	return 0;
 }

-- 
1.5.3.4

#################################################
Regards,
Arun C

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Resend][PATCH] Fix for the i2c initialization error on 2430sdp
  2008-06-09  6:25 [Resend][PATCH] Fix for the i2c initialization error on 2430sdp arun c
@ 2008-06-09 12:53 ` Eduardo Valentin
  2008-06-10 21:20   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Eduardo Valentin @ 2008-06-09 12:53 UTC (permalink / raw)
  To: arun c; +Cc: linux-omap, Chandra shekhar, Felipe Balbi

On Mon, Jun 9, 2008 at 2:25 AM, arun c <arunedarath@mistralsolutions.com> wrote:
> Hi all,
>
> Resending the patch after incorporating comments from
> Chandra , Eduardo Valentin and Felipe.
>
> ########################################################
>
>
> From ee2a6fd572c6d0464166fc8123982a38b36e7776 Mon Sep 17 00:00:00 2001
> From: arun <arunedarath@mistralsolutions.com>
> Date: Fri, 6 Jun 2008 18:18:50 +0530
> Subject: [PATCH] Fix for the i2c initialization error on 2430sdp
>
>
> Signed-off-by: arun <arunedarath@mistralsolutions.com>
Acked-by: Eduardo Valentin <eduardo.valentin@indt.org.br>
> ---
>  arch/arm/mach-omap2/board-2430sdp.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-2430sdp.c
> b/arch/arm/mach-omap2/board-2430sdp.c
> index e078a2a..780913e 100644
> --- a/arch/arm/mach-omap2/board-2430sdp.c
> +++ b/arch/arm/mach-omap2/board-2430sdp.c
> @@ -379,8 +379,12 @@ static struct omap_board_config_kernel
> sdp2430_config[] __initdata = {
>
>  static int __init omap2430_i2c_init(void)
>  {
> -       omap_register_i2c_bus(1, 400, NULL, 0);
> +       /*
> +        * Registering bus 2 first to avoid twl4030 misbehaving as 2430SDP
> +        * has twl4030 on bus 2
> +        */
>        omap_register_i2c_bus(2, 2600, NULL, 0);
> +       omap_register_i2c_bus(1, 400, NULL, 0);
>        return 0;
>  }
>
> --
> 1.5.3.4
>
> #################################################
> Regards,
> Arun C
>



-- 
Eduardo Bezerra Valentin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Resend][PATCH] Fix for the i2c initialization error on 2430sdp
  2008-06-09 12:53 ` Eduardo Valentin
@ 2008-06-10 21:20   ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2008-06-10 21:20 UTC (permalink / raw)
  To: Eduardo Valentin; +Cc: arun c, linux-omap, Chandra shekhar, Felipe Balbi

* Eduardo Valentin <edubezval@gmail.com> [080609 05:55]:
> On Mon, Jun 9, 2008 at 2:25 AM, arun c <arunedarath@mistralsolutions.com> wrote:
> > Hi all,
> >
> > Resending the patch after incorporating comments from
> > Chandra , Eduardo Valentin and Felipe.
> >
> > ########################################################
> >
> >
> > From ee2a6fd572c6d0464166fc8123982a38b36e7776 Mon Sep 17 00:00:00 2001
> > From: arun <arunedarath@mistralsolutions.com>
> > Date: Fri, 6 Jun 2008 18:18:50 +0530
> > Subject: [PATCH] Fix for the i2c initialization error on 2430sdp
> >
> >
> > Signed-off-by: arun <arunedarath@mistralsolutions.com>
> Acked-by: Eduardo Valentin <eduardo.valentin@indt.org.br>

Pushing today.

Tony


> > ---
> >  arch/arm/mach-omap2/board-2430sdp.c |    6 +++++-
> >  1 files changed, 5 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-2430sdp.c
> > b/arch/arm/mach-omap2/board-2430sdp.c
> > index e078a2a..780913e 100644
> > --- a/arch/arm/mach-omap2/board-2430sdp.c
> > +++ b/arch/arm/mach-omap2/board-2430sdp.c
> > @@ -379,8 +379,12 @@ static struct omap_board_config_kernel
> > sdp2430_config[] __initdata = {
> >
> >  static int __init omap2430_i2c_init(void)
> >  {
> > -       omap_register_i2c_bus(1, 400, NULL, 0);
> > +       /*
> > +        * Registering bus 2 first to avoid twl4030 misbehaving as 2430SDP
> > +        * has twl4030 on bus 2
> > +        */
> >        omap_register_i2c_bus(2, 2600, NULL, 0);
> > +       omap_register_i2c_bus(1, 400, NULL, 0);
> >        return 0;
> >  }
> >
> > --
> > 1.5.3.4
> >
> > #################################################
> > Regards,
> > Arun C
> >
> 
> 
> 
> -- 
> Eduardo Bezerra Valentin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-06-10 21:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-09  6:25 [Resend][PATCH] Fix for the i2c initialization error on 2430sdp arun c
2008-06-09 12:53 ` Eduardo Valentin
2008-06-10 21:20   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox