Re: [PATCH 10/21] ARM: OMAP: McBSP: Coding style cleanup on arch/arm/plat-omap/mcbsp.c

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Fri, Jun 06, 2008 at 06:30:42PM -0700, Tony Lindgren wrote:
> From: Eduardo Valentin <eduardo.valentin@indt.org.br>
> 
> This patch fix lots of warnings and errors reported by
> scripts/checkpatch.pl on arch/arm/plat-omap/mcbsp.c.
> 
> Signed-off-by: Eduardo Valentin <eduardo.valentin@indt.org.br>
> Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
> index 9cf83c4..053de31 100644
> --- a/arch/arm/plat-omap/mcbsp.c
> +++ b/arch/arm/plat-omap/mcbsp.c
> @@ -21,9 +21,8 @@
>  #include <linux/err.h>
>  #include <linux/clk.h>
>  #include <linux/delay.h>
> -
> -#include <asm/io.h>
> -#include <asm/irq.h>
> +#include <linux/io.h>
> +#include <linux/irq.h>

checkpatch isn't always right.  In the case of linux/irq.h vs asm/irq.h
they are not equivalent.  linux/irq.h is the genirq header file.  asm/irq.h
is the architecture irq.h file.  The two are quite different (unlike the
linux/io.h and asm/io.h case.)

Unless you're doing something with static IRQ numbers, you shouldn't need
either of these irq.h headers - the one you generally want for drivers is
linux/interrupt.h.