* Russell King - ARM Linux [080614 12:09]: > On Fri, Jun 06, 2008 at 06:30:51PM -0700, Tony Lindgren wrote: > > @@ -51,7 +50,7 @@ u32 omap_ctrl_readl(u16 offset) > > void omap_ctrl_writeb(u8 val, u16 offset) > > { > > pr_debug("omap_ctrl_writeb: writing 0x%0x to 0x%0x\n", val, > > - (u32)OMAP_CTRL_REGADDR(offset)); > > + (__force u32)OMAP_CTRL_REGADDR(offset)); > > Casting to unsigned long avoids the need for __force. __force should be > used sparingly. Alternatively, use '%p' to print a pointer. > > Apart from that, ok. I've actually removed the verbose debug lines, those can be patched in as needed. Refreshed patch following. Tony