From: Jarkko Nikula <jarkko.nikula@nokia.com>
To: ext Chandra shekhar <x0044955@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [RFC/PATCH 1/4] McBSP support for 34XX
Date: Wed, 18 Jun 2008 10:23:07 +0300 [thread overview]
Message-ID: <20080618102307.95d99f49.jarkko.nikula@nokia.com> (raw)
In-Reply-To: <003b01c8cfab$6f16edb0$318918ac@ent.ti.com>
On Mon, 16 Jun 2008 17:50:58 +0530
"ext Chandra shekhar" <x0044955@ti.com> wrote:
>
> Signed-off-by: chandra shekhar <x0044955@ti.com>
> ---
> arch/arm/configs/omap_3430sdp_defconfig | 1
> arch/arm/mach-omap2/mcbsp.c | 45 ++++++++++++++++++++++
> ++++++++++ arch/arm/plat-omap/mcbsp.c | 2 -
> include/asm-arm/arch-omap/mcbsp.h | 34 +++++++++++++++++++++
> +-- 4 files changed, 79 insertions(+), 3 deletions(-)
...
> +#define OMAP_MCBSP_BIT(ARG) ((0x01)<<(ARG))
>
> +#define DILB OMAP_MCBSP_BIT(5)
>
This OMAP_MCBSP_BIT(ARG) is needless. Usual (1 << 5) convention would
be better or follow the same 0x0020 convention what mcbsp.h is doing
currently.
Jarkko
prev parent reply other threads:[~2008-06-18 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 12:20 [RFC/PATCH 1/4] McBSP support for 34XX Chandra shekhar
2008-06-16 12:46 ` Tony Lindgren
2008-06-18 7:23 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080618102307.95d99f49.jarkko.nikula@nokia.com \
--to=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0044955@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox