* Russell King - ARM Linux [080614 11:20]: > On Fri, Jun 06, 2008 at 06:30:42PM -0700, Tony Lindgren wrote: > > From: Eduardo Valentin > > > > This patch fix lots of warnings and errors reported by > > scripts/checkpatch.pl on arch/arm/plat-omap/mcbsp.c. > > > > Signed-off-by: Eduardo Valentin > > Acked-by: Felipe Balbi > > Signed-off-by: Tony Lindgren > > > > diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c > > index 9cf83c4..053de31 100644 > > --- a/arch/arm/plat-omap/mcbsp.c > > +++ b/arch/arm/plat-omap/mcbsp.c > > @@ -21,9 +21,8 @@ > > #include > > #include > > #include > > - > > -#include > > -#include > > +#include > > +#include > > checkpatch isn't always right. In the case of linux/irq.h vs asm/irq.h > they are not equivalent. linux/irq.h is the genirq header file. asm/irq.h > is the architecture irq.h file. The two are quite different (unlike the > linux/io.h and asm/io.h case.) > > Unless you're doing something with static IRQ numbers, you shouldn't need > either of these irq.h headers - the one you generally want for drivers is > linux/interrupt.h. The include for irq.h can be left out. Updated patch below. Tony