From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: musb: ignore disconnect on suspend
Date: Mon, 23 Jun 2008 14:13:17 +0300 [thread overview]
Message-ID: <20080623111317.GQ7741@atomide.com> (raw)
In-Reply-To: <1213182432-23952-3-git-send-email-felipe.balbi@nokia.com>
* Felipe Balbi <felipe.balbi@nokia.com> [080611 14:09]:
> This still needed, otherwise tusb2.0 won't connect after
> a power cycle.
Pushing today.
Tony
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> drivers/usb/musb/musb_core.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 019898a..5b92f21 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -659,7 +659,11 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
> switch (musb->xceiv.state) {
> #ifdef CONFIG_USB_OTG
> case OTG_STATE_A_SUSPEND:
> - musb->ignore_disconnect = 0;
> + /* We need to ignore disconnect on suspend
> + * otherwise tusb 2.0 won't reconnect after a
> + * power cycle, which breaks otg compliance.
> + */
> + musb->ignore_disconnect = 1;
> musb_g_reset(musb);
> /* FALLTHROUGH */
> case OTG_STATE_A_WAIT_BCON: /* OPT TD.4.7-900ms */
> --
> 1.5.6.rc1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-06-23 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 11:07 [PATCH 0/2] musb patches Felipe Balbi
2008-06-11 11:07 ` [PATCH 1/2] usb: musb: MUSB_OTG should depend on PM Felipe Balbi
2008-06-11 11:07 ` [PATCH 2/2] usb: musb: ignore disconnect on suspend Felipe Balbi
2008-06-23 11:13 ` Tony Lindgren [this message]
2008-06-23 11:13 ` [PATCH 1/2] usb: musb: MUSB_OTG should depend on PM Tony Lindgren
2008-06-23 11:15 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623111317.GQ7741@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox