From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: musb: MUSB_OTG should depend on PM
Date: Mon, 23 Jun 2008 14:13:49 +0300 [thread overview]
Message-ID: <20080623111348.GR7741@atomide.com> (raw)
In-Reply-To: <1213182432-23952-2-git-send-email-felipe.balbi@nokia.com>
* Felipe Balbi <felipe.balbi@nokia.com> [080611 14:09]:
> Current musb Kconfig causes cyclic depency on x86
> arch. The best fix is to depend on PM in order to
> build on OTG mode.
>
> Anyone interested in reproducing the error in your
> linux-omap trees, just make ARCH=x86 menuconfig
I guess this is now obsolete with Dave's HAS_CLK patch?
Tony
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> drivers/usb/musb/Kconfig | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> index a485a86..acbbd5f 100644
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -88,10 +88,9 @@ config USB_MUSB_PERIPHERAL
> (With a "Mini-AB" connector, you should enable USB OTG.)
>
> config USB_MUSB_OTG
> - depends on USB && USB_GADGET && EXPERIMENTAL
> + depends on USB && USB_GADGET && PM && EXPERIMENTAL
> bool "Both host and peripheral: USB OTG (On The Go) Device"
> select USB_GADGET_MUSB_HDRC
> - select USB_OTG
> select PM
> help
> The most notable feature of USB OTG is support for a
> --
> 1.5.6.rc1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-06-23 11:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 11:07 [PATCH 0/2] musb patches Felipe Balbi
2008-06-11 11:07 ` [PATCH 1/2] usb: musb: MUSB_OTG should depend on PM Felipe Balbi
2008-06-11 11:07 ` [PATCH 2/2] usb: musb: ignore disconnect on suspend Felipe Balbi
2008-06-23 11:13 ` Tony Lindgren
2008-06-23 11:13 ` Tony Lindgren [this message]
2008-06-23 11:15 ` [PATCH 1/2] usb: musb: MUSB_OTG should depend on PM Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623111348.GR7741@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox