RE: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card

Kumar, Purushotam
2008-07-14T11:57:39Z

[-- Attachment #1: Type: text/plain, Size: 2224 bytes --]

Tony,

I updated patch for MMC1 and MMC2 and also refreshed the patch.
I am attaching patch with this mail.

Regards,
Purushotam

> -----Original Message-----
> From: Kumar, Purushotam
> Sent: Wednesday, June 25, 2008 3:34 PM
> To: Tony Lindgren; Purushotam Kumar
> Cc: linux-omap@vger.kernel.org; Gole, Anant
> Subject: RE: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
>
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony@atomide.com]
> > Sent: Monday, June 23, 2008 6:17 PM
> > To: Purushotam Kumar
> > Cc: linux-omap@vger.kernel.org; Gole, Anant
> > Subject: Re: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
> >
> > * Purushotam Kumar <a0876542@india.ti.com> [080616 16:03]:
> > > OMAP3:devices.c:Enabling 4-bit for SD card
> > >
> > > SD card was working in 1-bit mode.This patch will configure SD card in
> > > 4-bit mode and hence performance will increase.
> > >
> > > Signed-off-by: Purushotam Kumar <purushotam@ti.com>
> > > Acked-by: Madhusudhan Chikkature Rajashekar <madhu.cr@ti.com>
> > > ---
> > > arch/arm/plat-omap/devices.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > Index: linux-omap-2.6/arch/arm/plat-omap/devices.c
> > > ===================================================================
> > > --- linux-omap-2.6.orig/arch/arm/plat-omap/devices.c
> > > +++ linux-omap-2.6/arch/arm/plat-omap/devices.c
> > > @@ -292,8 +292,10 @@ static void __init omap_init_mmc(void)
> > > mmc = &mmc_conf->mmc[0];
> > >
> > > if (cpu_is_omap2430() || cpu_is_omap34xx()) {
> > > - if (mmc->enabled)
> > > + if (mmc->enabled) {
> > > + mmc1_data.conf = *mmc;
> > > (void) platform_device_register(&mmc_omap_device1);
> > > + }
> > >
> > > #if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP34XX)
> > > mmc = &mmc_conf->mmc[1];
> >
> > I guess this should be also done for mmc2_data.conf?
> >
> > Tony
>
> I agree with you that it is required to be done for MMC2 as well.
> Please push this patch for MMC1 and I will submit other patch latter for MMC2.
>
> Regards,
> Purushotam

[-- Attachment #2: enable_sd_4bit.patch --]
[-- Type: application/octet-stream, Size: 1121 bytes --]

OMAP3:devices.c:Enabling 4-bit for SD card

SD card was working in 1-bit mode.This patch will configure SD card in
4-bit mode and hence performance will increase.

Signed-off-by: Purushotam Kumar <purushotam@ti.com>
Acked-by: Madhusudhan Chikkature Rajashekar <madhu.cr@ti.com>
---
arch/arm/plat-omap/devices.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

Index: linux-omap-2.6/arch/arm/plat-omap/devices.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/plat-omap/devices.c
+++ linux-omap-2.6/arch/arm/plat-omap/devices.c
@@ -296,13 +296,17 @@ static void __init omap_init_mmc(void)
mmc = &mmc_conf->mmc[0];

if (cpu_is_omap2430() || cpu_is_omap34xx()) {
- if (mmc->enabled)
+ if (mmc->enabled) {
+ mmc1_data.conf = *mmc;
(void) platform_device_register(&mmc_omap_device1);
+ }

#if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP34XX)
mmc = &mmc_conf->mmc[1];
- if (mmc->enabled)
+ if (mmc->enabled) {
+ mmc2_data.conf = *mmc;
(void) platform_device_register(&mmc_omap_device2);
+ }
#endif

return;