From: Tony Lindgren <tony@atomide.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: felipe.balbi@nokia.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH] i2c: twl4030: warning: mixed declarations and code
Date: Mon, 23 Jun 2008 16:00:05 +0300 [thread overview]
Message-ID: <20080623130004.GX7741@atomide.com> (raw)
In-Reply-To: <a0580c510806110702m655cf96by6dbd9800ef48adf4@mail.gmail.com>
* Eduardo Valentin <edubezval@gmail.com> [080611 17:04]:
> Hi Balbi,
>
> On Wed, Jun 11, 2008 at 9:55 AM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> > On Wed, Jun 11, 2008 at 09:53:45AM -0400, ext Eduardo Valentin wrote:
> >> > - struct twl4030_usb *twl = xceiv_to_twl(xceiv);
> >> > u32 l;
> >> > + struct twl4030_usb *twl = xceiv_to_twl(xceiv);
> >>
> >> To me you are just moving the place of this declaration.
> >
> > Yes, because ISO C99 forbids mixed declaraction and code. build
> > tlw4030-usb and you'll see the warning. ;-)
>
> Ok. I'd suggest changing the commit message to
> i2c: twl4030: C99 warning: mixed declarations and code
>
> But this is up to you :)
Pushing today, that driver is not in mainline yet so the comments are
just fine.
Tony
prev parent reply other threads:[~2008-06-23 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 11:55 [PATCH] i2c: twl4030: warning: mixed declarations and code Felipe Balbi
2008-06-11 13:53 ` Eduardo Valentin
2008-06-11 13:55 ` Felipe Balbi
2008-06-11 14:02 ` Eduardo Valentin
2008-06-23 13:00 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623130004.GX7741@atomide.com \
--to=tony@atomide.com \
--cc=edubezval@gmail.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox