[PATCH] i2c: twl4030: warning: mixed declarations and code

[PATCH] i2c: twl4030: warning: mixed declarations and code

[Felipe Balbi]

Latest patches for multi-omap support introduced
it, removing.

Trivial patch.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 drivers/i2c/chips/twl4030-usb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/chips/twl4030-usb.c b/drivers/i2c/chips/twl4030-usb.c
index 7f93b4f..f546d42 100644
--- a/drivers/i2c/chips/twl4030-usb.c
+++ b/drivers/i2c/chips/twl4030-usb.c
@@ -625,8 +625,8 @@ static int twl4030_set_suspend(struct otg_transceiver *x, int suspend)
 static int twl4030_set_peripheral(struct otg_transceiver *xceiv,
 		struct usb_gadget *gadget)
 {
-	struct twl4030_usb *twl = xceiv_to_twl(xceiv);
 	u32 l;
+	struct twl4030_usb *twl = xceiv_to_twl(xceiv);
 
 	if (!xceiv)
 		return -ENODEV;
-- 
1.5.6.rc1

Re: [PATCH] i2c: twl4030: warning: mixed declarations and code

[Eduardo Valentin]

Hi Balbi,

Sorry but I didn't get your point with your patch.

On Wed, Jun 11, 2008 at 7:55 AM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> Latest patches for multi-omap support introduced
> it, removing.

What exactly you are removing?

>
> Trivial patch.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  drivers/i2c/chips/twl4030-usb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/chips/twl4030-usb.c b/drivers/i2c/chips/twl4030-usb.c
> index 7f93b4f..f546d42 100644
> --- a/drivers/i2c/chips/twl4030-usb.c
> +++ b/drivers/i2c/chips/twl4030-usb.c
> @@ -625,8 +625,8 @@ static int twl4030_set_suspend(struct otg_transceiver *x, int suspend)
>  static int twl4030_set_peripheral(struct otg_transceiver *xceiv,
>                struct usb_gadget *gadget)
>  {
> -       struct twl4030_usb *twl = xceiv_to_twl(xceiv);
>        u32 l;
> +       struct twl4030_usb *twl = xceiv_to_twl(xceiv);

To me you are just moving the place of this declaration.
>
>        if (!xceiv)
>                return -ENODEV;
> --
> 1.5.6.rc1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Eduardo Bezerra Valentin

Re: [PATCH] i2c: twl4030: warning: mixed declarations and code

[Felipe Balbi]

On Wed, Jun 11, 2008 at 09:53:45AM -0400, ext Eduardo Valentin wrote:
> > -       struct twl4030_usb *twl = xceiv_to_twl(xceiv);
> >        u32 l;
> > +       struct twl4030_usb *twl = xceiv_to_twl(xceiv);
> 
> To me you are just moving the place of this declaration.

Yes, because ISO C99 forbids mixed declaraction and code. build
tlw4030-usb and you'll see the warning. ;-)

-- 
	- Balbi

Re: [PATCH] i2c: twl4030: warning: mixed declarations and code

[Eduardo Valentin]

Hi Balbi,

On Wed, Jun 11, 2008 at 9:55 AM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> On Wed, Jun 11, 2008 at 09:53:45AM -0400, ext Eduardo Valentin wrote:
>> > -       struct twl4030_usb *twl = xceiv_to_twl(xceiv);
>> >        u32 l;
>> > +       struct twl4030_usb *twl = xceiv_to_twl(xceiv);
>>
>> To me you are just moving the place of this declaration.
>
> Yes, because ISO C99 forbids mixed declaraction and code. build
> tlw4030-usb and you'll see the warning. ;-)

Ok. I'd suggest changing the commit message to
i2c: twl4030: C99 warning: mixed declarations and code

But this is up to you :)

>
> --
>        - Balbi
>



-- 
Eduardo Bezerra Valentin

Re: [PATCH] i2c: twl4030: warning: mixed declarations and code

[Tony Lindgren]

* Eduardo Valentin <edubezval@gmail.com> [080611 17:04]:
> Hi Balbi,
> 
> On Wed, Jun 11, 2008 at 9:55 AM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> > On Wed, Jun 11, 2008 at 09:53:45AM -0400, ext Eduardo Valentin wrote:
> >> > -       struct twl4030_usb *twl = xceiv_to_twl(xceiv);
> >> >        u32 l;
> >> > +       struct twl4030_usb *twl = xceiv_to_twl(xceiv);
> >>
> >> To me you are just moving the place of this declaration.
> >
> > Yes, because ISO C99 forbids mixed declaraction and code. build
> > tlw4030-usb and you'll see the warning. ;-)
> 
> Ok. I'd suggest changing the commit message to
> i2c: twl4030: C99 warning: mixed declarations and code
> 
> But this is up to you :)

Pushing today, that driver is not in mainline yet so the comments are
just fine.

Tony