From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] i2c: twl4030: warning: mixed declarations and code Date: Mon, 23 Jun 2008 16:00:05 +0300 Message-ID: <20080623130004.GX7741@atomide.com> References: <1213185323-31758-1-git-send-email-felipe.balbi@nokia.com> <20080611135502.GI20671@gandalf.research.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [63.208.196.179] ([63.208.196.179]:61710 "EHLO mho-02-bos.mailhop.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753798AbYFWM7l (ORCPT ); Mon, 23 Jun 2008 08:59:41 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Eduardo Valentin Cc: felipe.balbi@nokia.com, linux-omap@vger.kernel.org * Eduardo Valentin [080611 17:04]: > Hi Balbi, > > On Wed, Jun 11, 2008 at 9:55 AM, Felipe Balbi wrote: > > On Wed, Jun 11, 2008 at 09:53:45AM -0400, ext Eduardo Valentin wrote: > >> > - struct twl4030_usb *twl = xceiv_to_twl(xceiv); > >> > u32 l; > >> > + struct twl4030_usb *twl = xceiv_to_twl(xceiv); > >> > >> To me you are just moving the place of this declaration. > > > > Yes, because ISO C99 forbids mixed declaraction and code. build > > tlw4030-usb and you'll see the warning. ;-) > > Ok. I'd suggest changing the commit message to > i2c: twl4030: C99 warning: mixed declarations and code > > But this is up to you :) Pushing today, that driver is not in mainline yet so the comments are just fine. Tony