From: Paul Walmsley <paul@pwsan.com>
To: linux-omap@vger.kernel.org
Cc: jouni.hogander@nokia.com, r-woodruff2@ti.com
Subject: [PATCH 4/4] OMAP3 PM: enable hardware SAR for USBHOST, USBTLL modules
Date: Wed, 25 Jun 2008 18:09:41 -0600 [thread overview]
Message-ID: <20080626000940.18779.94992.stgit@localhost.localdomain> (raw)
In-Reply-To: <20080626000415.18779.25924.stgit@localhost.localdomain>
Enable hardware save-and-restore for the CORE and USBHOST powerdomains
during PM layer initialization. On OMAP3, this only affects the
USBTLL and USBHOST modules.
There is probably a sleep and wakeup latency penalty with these
enabled. No one seems to have quantified it yet. If the added
latency is measurable, an alternate approach would be to only enable
hardware save-and-restore if there are USB devices attached.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
arch/arm/mach-omap2/pm34xx.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index c7493f5..202c269 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -357,6 +357,10 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm)
pwrst->pwrdm = pwrdm;
pwrst->next_state = PWRDM_POWER_RET;
list_add(&pwrst->node, &pwrst_list);
+
+ if (pwrdm_has_hdwr_sar(pwrdm))
+ pwrdm_enable_hdwr_sar(pwrdm);
+
return set_pwrdm_state(pwrst->pwrdm, pwrst->next_state);
}
next prev parent reply other threads:[~2008-06-26 0:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 0:09 [PATCH 0/4] OMAP3: fix powerdomain hardware save-and-restore support Paul Walmsley
2008-06-26 0:09 ` [PATCH 1/4] OMAP3 pwrdm: add hardware save-and-restore (SAR) support Paul Walmsley
2008-06-26 0:09 ` [PATCH 2/4] OMAP3: move USBHOST SAR handling from clock framework to powerdomain layer Paul Walmsley
2008-06-26 0:09 ` [PATCH 3/4] OMAP3 pwrdm: add CORE SAR handling (for USBTLL module) Paul Walmsley
2008-06-26 0:09 ` Paul Walmsley [this message]
2008-06-26 13:42 ` [PATCH 0/4] OMAP3: fix powerdomain hardware save-and-restore support Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080626000940.18779.94992.stgit@localhost.localdomain \
--to=paul@pwsan.com \
--cc=jouni.hogander@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=r-woodruff2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox