[PATCH 0/4] more musb/i2c patches

[PATCH 0/4] more musb/i2c patches

[Felipe Balbi]

Basically adding module_alias and allowing
some twl drivers to be dynamically linked.

There's also one patch to make hdrc_cnf.h
more "omap3-compliant" based on the musb
configuration for musb ip core on omap3.

Please, comment them out.

Felipe Balbi (4):
  usb: musb: musb on omap3 has 32 endpoints
  usb: musb: add MODULE_ALIAS for udev module loading
  i2c: allow twl modules to be built as modules
  i2c: add MODULE_ALIAS to twl4030 drivers

 drivers/i2c/chips/Kconfig                   |    6 +++---
 drivers/i2c/chips/twl4030-core.c            |    1 +
 drivers/i2c/chips/twl4030-gpio.c            |    1 +
 drivers/i2c/chips/twl4030-madc.c            |    1 +
 drivers/i2c/chips/twl4030-poweroff.c        |    1 +
 drivers/i2c/chips/twl4030-pwrbutton.c       |    1 +
 drivers/i2c/chips/twl4030-pwrirq.c          |    1 +
 drivers/i2c/chips/twl4030-usb.c             |    1 +
 drivers/input/keyboard/omap-twl4030keypad.c |    1 +
 drivers/rtc/rtc-twl4030.c                   |    1 +
 drivers/usb/musb/musb_core.c                |    4 +++-
 include/asm-arm/arch-omap/hdrc_cnf.h        |    6 +++---
 12 files changed, 18 insertions(+), 7 deletions(-)

[PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

[Felipe Balbi]

Fix hdrc_cnf.h for omap3 configuration.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 include/asm-arm/arch-omap/hdrc_cnf.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/asm-arm/arch-omap/hdrc_cnf.h b/include/asm-arm/arch-omap/hdrc_cnf.h
index 74c8432..271214c 100644
--- a/include/asm-arm/arch-omap/hdrc_cnf.h
+++ b/include/asm-arm/arch-omap/hdrc_cnf.h
@@ -14,11 +14,11 @@
 
 /* ** Number of Tx endpoints ** */
 /* Legal values are 1 - 16 (this value includes EP0) */
-#define MUSB_C_NUM_EPT 8
+#define MUSB_C_NUM_EPT 16
 
 /* ** Number of Rx endpoints ** */
 /* Legal values are 1 - 16 (this value includes EP0) */
-#define MUSB_C_NUM_EPR 8
+#define MUSB_C_NUM_EPR 16
 
 /* ** Endpoint 1 to 15 direction types ** */
 /* C_EP1_DEF is defined if either Tx endpoint 1 or Rx endpoint 1 are used */
@@ -163,7 +163,7 @@
  * Legal values are 2 - 16
  * This must be equal to the larger of C_NUM_EPT, C_NUM_EPR
  */
-#define MUSB_C_NUM_EPS 8
+#define MUSB_C_NUM_EPS 16
 
 /* C_EPMAX_BITS is equal to the largest endpoint FIFO word address bits */
 #define MUSB_C_EPMAX_BITS 12
-- 
1.5.6.rc1

[PATCH 2/4] usb: musb: add MODULE_ALIAS for udev module loading

[Felipe Balbi]

platform drivers should add MODULE_ALIAS for allowing
udev module loading.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 drivers/usb/musb/musb_core.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 5b92f21..75c3013 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -134,11 +134,13 @@ MODULE_PARM_DESC(debug, "initial debug message level");
 
 #define DRIVER_INFO DRIVER_DESC ", v" MUSB_VERSION
 
-const char musb_driver_name[] = "musb_hdrc";
+#define MUSB_DRIVER_NAME "musb_hdrc"
+const char musb_driver_name[] = MUSB_DRIVER_NAME;
 
 MODULE_DESCRIPTION(DRIVER_INFO);
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:" MUSB_DRIVER_NAME);
 
 
 /*-------------------------------------------------------------------------*/
-- 
1.5.6.rc1

[PATCH 3/4] i2c: allow twl modules to be built as modules

[Felipe Balbi]

Besides twl core and twl gpio, all the others can
be dynamically linked.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 drivers/i2c/chips/Kconfig |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig
index cba8abf..b421727 100644
--- a/drivers/i2c/chips/Kconfig
+++ b/drivers/i2c/chips/Kconfig
@@ -150,7 +150,7 @@ config TWL4030_MADC
 	  called twl4030-madc.ko
 
 config TWL4030_USB
-	bool "TWL4030 USB Transceiver Driver"
+	tristate "TWL4030 USB Transceiver Driver"
 	depends on TWL4030_CORE
 
 choice
@@ -170,11 +170,11 @@ config TWL4030_USB_HS_ULPI
 endchoice
 
 config TWL4030_PWRBUTTON
-	bool "TWL4030 Power button Driver"
+	tristate "TWL4030 Power button Driver"
 	depends on TWL4030_CORE
 
 config TWL4030_POWEROFF
-	bool "TWL4030 device poweroff"
+	tristate "TWL4030 device poweroff"
 	depends on TWL4030_CORE
 
 config SENSORS_MAX6875
-- 
1.5.6.rc1

[PATCH 4/4] i2c: add MODULE_ALIAS to twl4030 drivers

[Felipe Balbi]

When built as module, it helps udev to probe them.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 drivers/i2c/chips/twl4030-core.c            |    1 +
 drivers/i2c/chips/twl4030-gpio.c            |    1 +
 drivers/i2c/chips/twl4030-madc.c            |    1 +
 drivers/i2c/chips/twl4030-poweroff.c        |    1 +
 drivers/i2c/chips/twl4030-pwrbutton.c       |    1 +
 drivers/i2c/chips/twl4030-pwrirq.c          |    1 +
 drivers/i2c/chips/twl4030-usb.c             |    1 +
 drivers/input/keyboard/omap-twl4030keypad.c |    1 +
 drivers/rtc/rtc-twl4030.c                   |    1 +
 9 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/chips/twl4030-core.c b/drivers/i2c/chips/twl4030-core.c
index 8822653..adc45d4 100644
--- a/drivers/i2c/chips/twl4030-core.c
+++ b/drivers/i2c/chips/twl4030-core.c
@@ -908,6 +908,7 @@ static void __exit twl4030_exit(void)
 subsys_initcall(twl4030_init);
 module_exit(twl4030_exit);
 
+MODULE_ALIAS("i2c:" DRIVER_NAME);
 MODULE_AUTHOR("Texas Instruments, Inc.");
 MODULE_DESCRIPTION("I2C Core interface for TWL4030");
 MODULE_LICENSE("GPL");
diff --git a/drivers/i2c/chips/twl4030-gpio.c b/drivers/i2c/chips/twl4030-gpio.c
index a448943..f16a48b 100644
--- a/drivers/i2c/chips/twl4030-gpio.c
+++ b/drivers/i2c/chips/twl4030-gpio.c
@@ -827,6 +827,7 @@ static void __exit gpio_twl4030_exit(void)
 module_init(gpio_twl4030_init);
 module_exit(gpio_twl4030_exit);
 
+MODULE_ALIAS("i2c:twl4030-gpio");
 MODULE_AUTHOR("Texas Instruments, Inc.");
 MODULE_DESCRIPTION("GPIO interface for TWL4030");
 MODULE_LICENSE("GPL");
diff --git a/drivers/i2c/chips/twl4030-madc.c b/drivers/i2c/chips/twl4030-madc.c
index f53a3db..72b126b 100644
--- a/drivers/i2c/chips/twl4030-madc.c
+++ b/drivers/i2c/chips/twl4030-madc.c
@@ -448,6 +448,7 @@ static void __exit twl4030_madc_exit(void)
 module_init(twl4030_madc_init);
 module_exit(twl4030_madc_exit);
 
+MODULE_ALIAS("i2c:twl4030-adc");
 MODULE_AUTHOR("Nokia Corporation");
 MODULE_DESCRIPTION("twl4030 ADC driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/i2c/chips/twl4030-poweroff.c b/drivers/i2c/chips/twl4030-poweroff.c
index 57c7fc7..0ebab0b 100644
--- a/drivers/i2c/chips/twl4030-poweroff.c
+++ b/drivers/i2c/chips/twl4030-poweroff.c
@@ -70,6 +70,7 @@ static void __exit twl4030_poweroff_exit(void)
 module_init(twl4030_poweroff_init);
 module_exit(twl4030_poweroff_exit);
 
+MODULE_ALIAS("i2c:twl4030-poweroff");
 MODULE_DESCRIPTION("Triton2 device power off");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Peter De Schrijver");
diff --git a/drivers/i2c/chips/twl4030-pwrbutton.c b/drivers/i2c/chips/twl4030-pwrbutton.c
index cbc31aa..09adc67 100644
--- a/drivers/i2c/chips/twl4030-pwrbutton.c
+++ b/drivers/i2c/chips/twl4030-pwrbutton.c
@@ -154,6 +154,7 @@ static void __exit twl4030_pwrbutton_exit(void)
 module_init(twl4030_pwrbutton_init);
 module_exit(twl4030_pwrbutton_exit);
 
+MODULE_ALIAS("i2c:twl4030-pwrbutton");
 MODULE_DESCRIPTION("Triton2 Power Button");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Peter De Schrijver");
diff --git a/drivers/i2c/chips/twl4030-pwrirq.c b/drivers/i2c/chips/twl4030-pwrirq.c
index 8f1fec6..a4d2e92 100644
--- a/drivers/i2c/chips/twl4030-pwrirq.c
+++ b/drivers/i2c/chips/twl4030-pwrirq.c
@@ -222,5 +222,6 @@ static void __exit twl4030_pwrirq_exit(void)
 	}
 }
 
+MODULE_ALIAS("i2c:twl4030-pwrirq");
 subsys_initcall(twl4030_pwrirq_init);
 module_exit(twl4030_pwrirq_exit);
diff --git a/drivers/i2c/chips/twl4030-usb.c b/drivers/i2c/chips/twl4030-usb.c
index f546d42..ab335ca 100644
--- a/drivers/i2c/chips/twl4030-usb.c
+++ b/drivers/i2c/chips/twl4030-usb.c
@@ -770,6 +770,7 @@ static void __exit twl4030_usb_exit(void)
 subsys_initcall(twl4030_usb_init);
 module_exit(twl4030_usb_exit);
 
+MODULE_ALIAS("i2c:twl4030-usb");
 MODULE_AUTHOR("Texas Instruments, Inc.");
 MODULE_DESCRIPTION("TWL4030 USB transceiver driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/input/keyboard/omap-twl4030keypad.c b/drivers/input/keyboard/omap-twl4030keypad.c
index 0344b4c..94ab43b 100644
--- a/drivers/input/keyboard/omap-twl4030keypad.c
+++ b/drivers/input/keyboard/omap-twl4030keypad.c
@@ -368,6 +368,7 @@ static void __exit omap_kp_exit(void)
 
 module_init(omap_kp_init);
 module_exit(omap_kp_exit);
+MODULE_ALIAS("platform:omap_twl4030keypad");
 MODULE_AUTHOR("Texas Instruments");
 MODULE_DESCRIPTION("OMAP TWL4030 Keypad Driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/rtc/rtc-twl4030.c b/drivers/rtc/rtc-twl4030.c
index ef0e175..e9386ba 100644
--- a/drivers/rtc/rtc-twl4030.c
+++ b/drivers/rtc/rtc-twl4030.c
@@ -647,6 +647,7 @@ static void __exit twl4030_rtc_exit(void)
 	platform_driver_unregister(&twl4030rtc_driver);
 }
 
+MODULE_ALIAS("platform:twl4030_rtc");
 MODULE_AUTHOR("Texas Instruments, MontaVista Software");
 MODULE_LICENSE("GPL");;
 
-- 
1.5.6.rc1

Re: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

[Tony Lindgren]

* Felipe Balbi <felipe.balbi@nokia.com> [080613 13:05]:
> Fix hdrc_cnf.h for omap3 configuration.

Does this break the configuration for omap2?

We should set these dynamically if different for omap2 and omap3
so we can compile both into the same kernel.

Tony

> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  include/asm-arm/arch-omap/hdrc_cnf.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/asm-arm/arch-omap/hdrc_cnf.h b/include/asm-arm/arch-omap/hdrc_cnf.h
> index 74c8432..271214c 100644
> --- a/include/asm-arm/arch-omap/hdrc_cnf.h
> +++ b/include/asm-arm/arch-omap/hdrc_cnf.h
> @@ -14,11 +14,11 @@
>  
>  /* ** Number of Tx endpoints ** */
>  /* Legal values are 1 - 16 (this value includes EP0) */
> -#define MUSB_C_NUM_EPT 8
> +#define MUSB_C_NUM_EPT 16
>  
>  /* ** Number of Rx endpoints ** */
>  /* Legal values are 1 - 16 (this value includes EP0) */
> -#define MUSB_C_NUM_EPR 8
> +#define MUSB_C_NUM_EPR 16
>  
>  /* ** Endpoint 1 to 15 direction types ** */
>  /* C_EP1_DEF is defined if either Tx endpoint 1 or Rx endpoint 1 are used */
> @@ -163,7 +163,7 @@
>   * Legal values are 2 - 16
>   * This must be equal to the larger of C_NUM_EPT, C_NUM_EPR
>   */
> -#define MUSB_C_NUM_EPS 8
> +#define MUSB_C_NUM_EPS 16
>  
>  /* C_EPMAX_BITS is equal to the largest endpoint FIFO word address bits */
>  #define MUSB_C_EPMAX_BITS 12
> -- 
> 1.5.6.rc1
> 

Re: [PATCH 2/4] usb: musb: add MODULE_ALIAS for udev module loading

[Tony Lindgren]

* Felipe Balbi <felipe.balbi@nokia.com> [080613 13:06]:
> platform drivers should add MODULE_ALIAS for allowing
> udev module loading.

Pushing today.

Tony

> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  drivers/usb/musb/musb_core.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 5b92f21..75c3013 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -134,11 +134,13 @@ MODULE_PARM_DESC(debug, "initial debug message level");
>  
>  #define DRIVER_INFO DRIVER_DESC ", v" MUSB_VERSION
>  
> -const char musb_driver_name[] = "musb_hdrc";
> +#define MUSB_DRIVER_NAME "musb_hdrc"
> +const char musb_driver_name[] = MUSB_DRIVER_NAME;
>  
>  MODULE_DESCRIPTION(DRIVER_INFO);
>  MODULE_AUTHOR(DRIVER_AUTHOR);
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:" MUSB_DRIVER_NAME);
>  
>  
>  /*-------------------------------------------------------------------------*/
> -- 
> 1.5.6.rc1
> 

Re: [PATCH 3/4] i2c: allow twl modules to be built as modules

[Tony Lindgren]

* Felipe Balbi <felipe.balbi@nokia.com> [080613 13:05]:
> Besides twl core and twl gpio, all the others can
> be dynamically linked.

Pushing today.

Tony

> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  drivers/i2c/chips/Kconfig |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig
> index cba8abf..b421727 100644
> --- a/drivers/i2c/chips/Kconfig
> +++ b/drivers/i2c/chips/Kconfig
> @@ -150,7 +150,7 @@ config TWL4030_MADC
>  	  called twl4030-madc.ko
>  
>  config TWL4030_USB
> -	bool "TWL4030 USB Transceiver Driver"
> +	tristate "TWL4030 USB Transceiver Driver"
>  	depends on TWL4030_CORE
>  
>  choice
> @@ -170,11 +170,11 @@ config TWL4030_USB_HS_ULPI
>  endchoice
>  
>  config TWL4030_PWRBUTTON
> -	bool "TWL4030 Power button Driver"
> +	tristate "TWL4030 Power button Driver"
>  	depends on TWL4030_CORE
>  
>  config TWL4030_POWEROFF
> -	bool "TWL4030 device poweroff"
> +	tristate "TWL4030 device poweroff"
>  	depends on TWL4030_CORE
>  
>  config SENSORS_MAX6875
> -- 
> 1.5.6.rc1
> 

Re: [PATCH 4/4] i2c: add MODULE_ALIAS to twl4030 drivers

[Tony Lindgren]

* Felipe Balbi <felipe.balbi@nokia.com> [080613 13:06]:
> When built as module, it helps udev to probe them.

Pushing today.

Tony


> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
>  drivers/i2c/chips/twl4030-core.c            |    1 +
>  drivers/i2c/chips/twl4030-gpio.c            |    1 +
>  drivers/i2c/chips/twl4030-madc.c            |    1 +
>  drivers/i2c/chips/twl4030-poweroff.c        |    1 +
>  drivers/i2c/chips/twl4030-pwrbutton.c       |    1 +
>  drivers/i2c/chips/twl4030-pwrirq.c          |    1 +
>  drivers/i2c/chips/twl4030-usb.c             |    1 +
>  drivers/input/keyboard/omap-twl4030keypad.c |    1 +
>  drivers/rtc/rtc-twl4030.c                   |    1 +
>  9 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/i2c/chips/twl4030-core.c b/drivers/i2c/chips/twl4030-core.c
> index 8822653..adc45d4 100644
> --- a/drivers/i2c/chips/twl4030-core.c
> +++ b/drivers/i2c/chips/twl4030-core.c
> @@ -908,6 +908,7 @@ static void __exit twl4030_exit(void)
>  subsys_initcall(twl4030_init);
>  module_exit(twl4030_exit);
>  
> +MODULE_ALIAS("i2c:" DRIVER_NAME);
>  MODULE_AUTHOR("Texas Instruments, Inc.");
>  MODULE_DESCRIPTION("I2C Core interface for TWL4030");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/i2c/chips/twl4030-gpio.c b/drivers/i2c/chips/twl4030-gpio.c
> index a448943..f16a48b 100644
> --- a/drivers/i2c/chips/twl4030-gpio.c
> +++ b/drivers/i2c/chips/twl4030-gpio.c
> @@ -827,6 +827,7 @@ static void __exit gpio_twl4030_exit(void)
>  module_init(gpio_twl4030_init);
>  module_exit(gpio_twl4030_exit);
>  
> +MODULE_ALIAS("i2c:twl4030-gpio");
>  MODULE_AUTHOR("Texas Instruments, Inc.");
>  MODULE_DESCRIPTION("GPIO interface for TWL4030");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/i2c/chips/twl4030-madc.c b/drivers/i2c/chips/twl4030-madc.c
> index f53a3db..72b126b 100644
> --- a/drivers/i2c/chips/twl4030-madc.c
> +++ b/drivers/i2c/chips/twl4030-madc.c
> @@ -448,6 +448,7 @@ static void __exit twl4030_madc_exit(void)
>  module_init(twl4030_madc_init);
>  module_exit(twl4030_madc_exit);
>  
> +MODULE_ALIAS("i2c:twl4030-adc");
>  MODULE_AUTHOR("Nokia Corporation");
>  MODULE_DESCRIPTION("twl4030 ADC driver");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/i2c/chips/twl4030-poweroff.c b/drivers/i2c/chips/twl4030-poweroff.c
> index 57c7fc7..0ebab0b 100644
> --- a/drivers/i2c/chips/twl4030-poweroff.c
> +++ b/drivers/i2c/chips/twl4030-poweroff.c
> @@ -70,6 +70,7 @@ static void __exit twl4030_poweroff_exit(void)
>  module_init(twl4030_poweroff_init);
>  module_exit(twl4030_poweroff_exit);
>  
> +MODULE_ALIAS("i2c:twl4030-poweroff");
>  MODULE_DESCRIPTION("Triton2 device power off");
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Peter De Schrijver");
> diff --git a/drivers/i2c/chips/twl4030-pwrbutton.c b/drivers/i2c/chips/twl4030-pwrbutton.c
> index cbc31aa..09adc67 100644
> --- a/drivers/i2c/chips/twl4030-pwrbutton.c
> +++ b/drivers/i2c/chips/twl4030-pwrbutton.c
> @@ -154,6 +154,7 @@ static void __exit twl4030_pwrbutton_exit(void)
>  module_init(twl4030_pwrbutton_init);
>  module_exit(twl4030_pwrbutton_exit);
>  
> +MODULE_ALIAS("i2c:twl4030-pwrbutton");
>  MODULE_DESCRIPTION("Triton2 Power Button");
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Peter De Schrijver");
> diff --git a/drivers/i2c/chips/twl4030-pwrirq.c b/drivers/i2c/chips/twl4030-pwrirq.c
> index 8f1fec6..a4d2e92 100644
> --- a/drivers/i2c/chips/twl4030-pwrirq.c
> +++ b/drivers/i2c/chips/twl4030-pwrirq.c
> @@ -222,5 +222,6 @@ static void __exit twl4030_pwrirq_exit(void)
>  	}
>  }
>  
> +MODULE_ALIAS("i2c:twl4030-pwrirq");
>  subsys_initcall(twl4030_pwrirq_init);
>  module_exit(twl4030_pwrirq_exit);
> diff --git a/drivers/i2c/chips/twl4030-usb.c b/drivers/i2c/chips/twl4030-usb.c
> index f546d42..ab335ca 100644
> --- a/drivers/i2c/chips/twl4030-usb.c
> +++ b/drivers/i2c/chips/twl4030-usb.c
> @@ -770,6 +770,7 @@ static void __exit twl4030_usb_exit(void)
>  subsys_initcall(twl4030_usb_init);
>  module_exit(twl4030_usb_exit);
>  
> +MODULE_ALIAS("i2c:twl4030-usb");
>  MODULE_AUTHOR("Texas Instruments, Inc.");
>  MODULE_DESCRIPTION("TWL4030 USB transceiver driver");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/input/keyboard/omap-twl4030keypad.c b/drivers/input/keyboard/omap-twl4030keypad.c
> index 0344b4c..94ab43b 100644
> --- a/drivers/input/keyboard/omap-twl4030keypad.c
> +++ b/drivers/input/keyboard/omap-twl4030keypad.c
> @@ -368,6 +368,7 @@ static void __exit omap_kp_exit(void)
>  
>  module_init(omap_kp_init);
>  module_exit(omap_kp_exit);
> +MODULE_ALIAS("platform:omap_twl4030keypad");
>  MODULE_AUTHOR("Texas Instruments");
>  MODULE_DESCRIPTION("OMAP TWL4030 Keypad Driver");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/rtc/rtc-twl4030.c b/drivers/rtc/rtc-twl4030.c
> index ef0e175..e9386ba 100644
> --- a/drivers/rtc/rtc-twl4030.c
> +++ b/drivers/rtc/rtc-twl4030.c
> @@ -647,6 +647,7 @@ static void __exit twl4030_rtc_exit(void)
>  	platform_driver_unregister(&twl4030rtc_driver);
>  }
>  
> +MODULE_ALIAS("platform:twl4030_rtc");
>  MODULE_AUTHOR("Texas Instruments, MontaVista Software");
>  MODULE_LICENSE("GPL");;
>  
> -- 
> 1.5.6.rc1
> 

Re: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

[Felipe Balbi]

On Mon, Jun 23, 2008 at 02:10:09PM +0300, Tony Lindgren wrote:
> * Felipe Balbi <felipe.balbi@nokia.com> [080613 13:05]:
> > Fix hdrc_cnf.h for omap3 configuration.
> 
> Does this break the configuration for omap2?
> 
> We should set these dynamically if different for omap2 and omap3
> so we can compile both into the same kernel.

Should check omap2430 trm to be sure, maybe someone in TI could help us
with it ?

Maybe we could bring it via platform_data as well?

-- 
	- Balbi

Re: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

[Tony Lindgren]

* Felipe Balbi <felipe.balbi@nokia.com> [080623 14:16]:
> On Mon, Jun 23, 2008 at 02:10:09PM +0300, Tony Lindgren wrote:
> > * Felipe Balbi <felipe.balbi@nokia.com> [080613 13:05]:
> > > Fix hdrc_cnf.h for omap3 configuration.
> > 
> > Does this break the configuration for omap2?
> > 
> > We should set these dynamically if different for omap2 and omap3
> > so we can compile both into the same kernel.
> 
> Should check omap2430 trm to be sure, maybe someone in TI could help us
> with it ?
> 
> Maybe we could bring it via platform_data as well?

Yeah that would be nice.

Tony

RE: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

[Gadiyar, Anand]

> > > Fix hdrc_cnf.h for omap3 configuration.
> >
> > Does this break the configuration for omap2?
> >
> > We should set these dynamically if different for omap2 and omap3
> > so we can compile both into the same kernel.
>
> Should check omap2430 trm to be sure, maybe someone in TI
> could help us with it ?

It won't break the 2430. The 2430 has 32 endpoints as well.


> Maybe we could bring it via platform_data as well?

Yep. That would be good.

- Anand

Re: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

[Felipe Balbi]

On Tue, Jun 24, 2008 at 09:52:05AM +0530, Gadiyar, Anand wrote:
> > > > Fix hdrc_cnf.h for omap3 configuration.
> > >
> > > Does this break the configuration for omap2?
> > >
> > > We should set these dynamically if different for omap2 and omap3
> > > so we can compile both into the same kernel.
> >
> > Should check omap2430 trm to be sure, maybe someone in TI
> > could help us with it ?
> 
> It won't break the 2430. The 2430 has 32 endpoints as well.

Good.

> > Maybe we could bring it via platform_data as well?
> 
> Yep. That would be good.

Cool, I'll start doing it.

Tony, maybe is safe to push this one so we can use all 32 endpoints ?

Meanwhile I'll create a way for different boards to tell musb driver its
configuration details.

-- 
Best Regards,

Felipe Balbi
me@felipebalbi.com
http://blog.felipebalbi.com

Re: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

[Dmitry Krivoschekov]

apologies for being late with my comment, and it might be not directly
related  to the initial patch but,

Gadiyar, Anand wrote:
>>>> Fix hdrc_cnf.h for omap3 configuration.
>>> Does this break the configuration for omap2?
>>>
>>> We should set these dynamically if different for omap2 and omap3
>>> so we can compile both into the same kernel.
>> Should check omap2430 trm to be sure, maybe someone in TI
>> could help us with it ?
>
> It won't break the 2430. The 2430 has 32 endpoints as well.
to be more precise, OMAP2430 has 1 control + 15 TX + 15 RX endpoints,
i.e.total of 31 eps.

To me it's not clear if these TX/RX endpoints is really independent.  In
other words,  is it
really possible to schedule for example 1st TX and 1st RX endpoint at
the same time (in the same USB frame)?

If you look at Felipe's patch, it changes a total number of eps from 8
to 16. In my understanding the driver is now able to schedule only this
number of endpoints. That is, the driver consider both 1TX and 1RX
endpoints as the same endpoint that is able to operate for Tx and Rx.
And, the driver can use only 16 endpoints at the same time, not 31.

But if all those 15Tx and 15Rx eps are mutually independent then it
makes sense to treat them in another way, MUSB_C_NUM_EPS should be 31
plus appropriate modifications to the driver are needed.


Of course I may be missing something, please correct me if I'm wrong
with my conclusions.


Thanks,
Dmitry
>
>
>> Maybe we could bring it via platform_data as well?
>
> Yep. That would be good.
>
> - Anand
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

[Tony Lindgren]

* Dmitry Krivoschekov <dmitry.krivoschekov@gmail.com> [080625 17:46]:
> apologies for being late with my comment, and it might be not directly
> related  to the initial patch but,
> 
> Gadiyar, Anand wrote:
> >>>> Fix hdrc_cnf.h for omap3 configuration.
> >>> Does this break the configuration for omap2?
> >>>
> >>> We should set these dynamically if different for omap2 and omap3
> >>> so we can compile both into the same kernel.
> >> Should check omap2430 trm to be sure, maybe someone in TI
> >> could help us with it ?
> >
> > It won't break the 2430. The 2430 has 32 endpoints as well.
> to be more precise, OMAP2430 has 1 control + 15 TX + 15 RX endpoints,
> i.e.total of 31 eps.
> 
> To me it's not clear if these TX/RX endpoints is really independent.  In
> other words,  is it
> really possible to schedule for example 1st TX and 1st RX endpoint at
> the same time (in the same USB frame)?
> 
> If you look at Felipe's patch, it changes a total number of eps from 8
> to 16. In my understanding the driver is now able to schedule only this
> number of endpoints. That is, the driver consider both 1TX and 1RX
> endpoints as the same endpoint that is able to operate for Tx and Rx.
> And, the driver can use only 16 endpoints at the same time, not 31.
> 
> But if all those 15Tx and 15Rx eps are mutually independent then it
> makes sense to treat them in another way, MUSB_C_NUM_EPS should be 31
> plus appropriate modifications to the driver are needed.
> 
> 
> Of course I may be missing something, please correct me if I'm wrong
> with my conclusions.

Let's wait on this until Felipe has the patch for getting the endpoint
configuration from board-*.c files.

Tony

> 
> 
> Thanks,
> Dmitry
> >
> >
> >> Maybe we could bring it via platform_data as well?
> >
> > Yep. That would be good.
> >
> > - Anand
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
>