From: "Peter 'p2' De Schrijver" <peter.de-schrijver@nokia.com>
To: ext Rajendra Nayak <rnayak@ti.com>
Cc: igor.stoppa@nokia.com, sawant@ti.com, linux-omap@vger.kernel.org
Subject: Re: FW: [PATCH 00/05] 34XX cpu idle patches - core off
Date: Fri, 27 Jun 2008 16:54:18 +0300 [thread overview]
Message-ID: <20080627135418.GG4509@codecarver.research.nokia.com> (raw)
In-Reply-To: <008201c8d84d$0577d540$68bf18ac@ent.ti.com>
On Fri, Jun 27, 2008 at 05:27:48PM +0530, ext Rajendra Nayak wrote:
> Hi Peter,
>
> I have the CORE off working on top of Jouni's latest patch set posted on l-o.
>
> 2 issues which I saw due to which CORE OFF was broken
> 1) Control module registers were redefined with the same name in control.h while my patches
> defined them in cpuidle34xx.h. In control.h they were just offsets and in cpuidle34xx.h they were defined as physical address.
> While saving the control module context, the offset was getting passed to omap_readl resulting in a crash.
> 2) GPIO clocks disable was moved into SRAM code in Jouni's patch, which would not get executed in OFF path.
>
Thanks. I'm testing them now. 013-TIPATCH-fix-core-off.patch patches
include/asm/arch/control.h which doesn't exist on a non-configured
kernel. It's better to have the patch modify
include/asm-arm/arch-omap/control.h.
Cheers,
Peter.
--
goa is a state of mind
next parent reply other threads:[~2008-06-27 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <008101c8d091$27d64bd0$68bf18ac@ent.ti.com>
[not found] ` <20080619114823.GB4953@codecarver.research.nokia.com>
[not found] ` <001d01c8d203$5cac7500$68bf18ac@ent.ti.com>
[not found] ` <20080619120507.GC4953@codecarver.research.nokia.com>
[not found] ` <001e01c8d205$a89ed4b0$68bf18ac@ent.ti.com>
[not found] ` <20080623144018.GC4468@codecarver.research.nokia.com>
[not found] ` <008201c8d84d$0577d540$68bf18ac@ent.ti.com>
2008-06-27 13:54 ` Peter 'p2' De Schrijver [this message]
2008-06-30 10:43 ` FW: [PATCH 00/05] 34XX cpu idle patches - core off Peter 'p2' De Schrijver
2008-06-30 12:45 ` Woodruff, Richard
2008-06-30 12:43 ` Igor Stoppa
2008-06-30 13:25 ` Woodruff, Richard
2008-06-30 14:47 ` Peter 'p2' De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080627135418.GG4509@codecarver.research.nokia.com \
--to=peter.de-schrijver@nokia.com \
--cc=igor.stoppa@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=sawant@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox