From: Tony Lindgren <tony@atomide.com>
To: Mikko Ylinen <mikko.k.ylinen@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: Store switch state for OUTPUT gpio-switches
Date: Thu, 3 Jul 2008 13:20:29 +0300 [thread overview]
Message-ID: <20080703102027.GH14276@atomide.com> (raw)
In-Reply-To: <1214832774-24114-1-git-send-email-mikko.k.ylinen@nokia.com>
* Mikko Ylinen <mikko.k.ylinen@nokia.com> [080630 16:35]:
Pushing today.
Tony
> Signed-off-by: Mikko Ylinen <mikko.k.ylinen@nokia.com>
> ---
> arch/arm/plat-omap/gpio-switch.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-omap/gpio-switch.c b/arch/arm/plat-omap/gpio-switch.c
> index cd96c00..7a61d0e 100644
> --- a/arch/arm/plat-omap/gpio-switch.c
> +++ b/arch/arm/plat-omap/gpio-switch.c
> @@ -131,11 +131,12 @@ static ssize_t gpio_sw_state_store(struct device *dev,
>
> str = get_sw_str(sw);
> if (strcmp(state, str[0]) == 0)
> - enable = 0;
> + sw->state = enable = 0;
> else if (strcmp(state, str[1]) == 0)
> - enable = 1;
> + sw->state = enable = 1;
> else
> return -EINVAL;
> +
> if (sw->flags & OMAP_GPIO_SWITCH_FLAG_INVERTED)
> enable = !enable;
> omap_set_gpio_dataout(sw->gpio, enable);
> --
> 1.5.5.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-07-03 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 13:32 [PATCH] OMAP: Store switch state for OUTPUT gpio-switches Mikko Ylinen
2008-07-03 10:20 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703102027.GH14276@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=mikko.k.ylinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox