Re: [RESEND][PATCH]Separate out 3430 LCD panel support from 2430 file

[Tony Lindgren <tony@atomide.com>]

* andrzej zaborowski <balrogg@gmail.com> [080704 19:34]:
> 2008/7/2  <iqbal@ti.com>:
> > From: Iqbal Shareef <iqbal@ti.com>
> >
> > Separate out 3430 LCD panel support from 2430 SDP.
> >
> > Currently the support for the LCD on 3430SDP is added in the lcd_2430sdp.c
> > file. This patch separates it out to a new file.
> 
> Isn't this a bit step backwards?  Code reuse is generally a good thing
> if it doesn't clutter the code too much, and if you do diff -pNaur
> lcd_2430sdp.c lcd_3430sdp.c in the current tree you will see that they
> are very similar.

Good point. I'll revert this patch, that should fix the compile issue
too.

Tony

> Additionally this patch leaves some of the 3430SDP code in
> lcd_2430sdp.c, you will still find this:
> #define SDP3430_LCD_PANEL_BACKLIGHT_GPIO 	24
> #define SDP3430_LCD_PANEL_ENABLE_GPIO 		28
> ...
> 	if (machine_is_omap_3430sdp()) {
> 		enable_gpio    = SDP3430_LCD_PANEL_ENABLE_GPIO;
> 		backlight_gpio = SDP3430_LCD_PANEL_BACKLIGHT_GPIO;
> 	} else {
> 		enable_gpio    = SDP2430_LCD_PANEL_ENABLE_GPIO;
> 		backlight_gpio = SDP2430_LCD_PANEL_BACKLIGHT_GPIO;
> 	}
> ...
> 	if (machine_is_omap_3430sdp()) {
> 		ded_reg = TWL4030_VAUX3_DEDICATED;
> 		ded_val = ENABLE_VAUX3_DEDICATED;
> 		grp_reg = TWL4030_VAUX3_DEV_GRP;
> 		grp_val = ENABLE_VAUX3_DEV_GRP;
> 	} else {
> 		ded_reg = TWL4030_VAUX2_DEDICATED;
> 		ded_val = ENABLE_VAUX2_DEDICATED;
> 		grp_reg = TWL4030_VAUX2_DEV_GRP;
> 		grp_val = ENABLE_VAUX2_DEV_GRP;
> 	}
> 
> Another thing that isn't explained is why the GPIO numbers for
> backlight and enable changed from 24 and 28 to 8 and 5.
> 
> Regards,
> Andrew
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html