From: Felipe Balbi <me@felipebalbi.com>
To: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] Set correct off mode polarity
Date: Mon, 21 Jul 2008 20:22:31 +0300 [thread overview]
Message-ID: <20080721172229.GA4738@frodo> (raw)
In-Reply-To: <1216656125-5800-1-git-send-email-peter.de-schrijver@nokia.com>
Hi,
style comments inlined.
On Mon, Jul 21, 2008 at 07:02:02PM +0300, Peter 'p2' De Schrijver wrote:
> +#define OFFMODE_POL (1<<3)
add spaces after 1 and before 3 (1 << 3)
> -
unnecessary change ?!?
--
balbi
next prev parent reply other threads:[~2008-07-21 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 16:02 [PATCH] Set correct off mode polarity Peter 'p2' De Schrijver
2008-07-21 16:02 ` [PATCH] Enable SYSOFFMODE use Peter 'p2' De Schrijver
2008-07-21 16:02 ` [PATCH] Add SYSOFFMODE option Peter 'p2' De Schrijver
2008-07-21 16:02 ` [PATCH] Load triton2 scripts Peter 'p2' De Schrijver
2008-07-21 17:32 ` Felipe Balbi
2008-08-05 10:50 ` [PATCH] Enable SYSOFFMODE use Tony Lindgren
2008-08-06 11:15 ` Kalle Jokiniemi
2008-08-06 17:12 ` Woodruff, Richard
2008-08-07 7:11 ` Kalle Jokiniemi
2008-08-08 1:18 ` Woodruff, Richard
2008-07-21 17:22 ` Felipe Balbi [this message]
2008-07-23 13:26 ` [PATCH] Set correct off mode polarity Peter 'p2' De Schrijver
2008-07-23 18:24 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2008-07-21 16:17 RFC: OMAP3 SYS_OFF_MODE support Peter 'p2' De Schrijver
2008-07-21 16:17 ` [PATCH] Set correct off mode polarity Peter 'p2' De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721172229.GA4738@frodo \
--to=me@felipebalbi.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox