From: David Brownell <david-b@pacbell.net>
To: "Kamat, Nishant" <nskamat@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Kyungmin Park <kmpark@infradead.org>
Subject: Re: [PATCH] MTD: OMAP2-NAND: Fix partition reading from board info
Date: Mon, 4 Aug 2008 13:02:46 -0700 [thread overview]
Message-ID: <200808041302.46323.david-b@pacbell.net> (raw)
In-Reply-To: <20080804142426.GK8885@atomide.com>
On Monday 04 August 2008, Tony Lindgren wrote:
> Looks like this driver does not exist outside linux-omap tree,
> care to send the whole driver to MTD list?
Unless someone created a big-endian OMAP, the cpu_to_le16()
calls in the read/write buffer calls can be removed ... and
then the read buffer code can use __raw_readsw(...) to get
what's been a significant speedup on some other ARMs. (The
atmel_nand.c code should be usable as-is.)
If there are big-endian OMAPs, it's still unclear why that
would be needed (maybe the hardware ECC code would need to
become byteorder-aware?) ... little point in byteswapping
on the i/o paths, except maybe to slow things down.
It'd make sense to merge the driver version which handles
both OMAP2 and OMAP3, too. With beagleboard.org pushing
out those puppies, the omap3 support matters more. :)
- Dave
next prev parent reply other threads:[~2008-08-04 20:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 14:32 [PATCH] MTD: OMAP2-NAND: Fix partition reading from board info Kamat, Nishant
2008-07-01 23:27 ` Kyungmin Park
2008-07-03 9:18 ` Kamat, Nishant
2008-08-04 14:24 ` Tony Lindgren
2008-08-04 20:02 ` David Brownell [this message]
2008-08-04 20:17 ` Lennert Buytenhek
2008-08-04 20:26 ` David Brownell
2008-08-04 20:56 ` Lennert Buytenhek
2008-08-04 21:37 ` David Brownell
2008-08-04 21:42 ` Lennert Buytenhek
2008-08-04 21:23 ` Woodruff, Richard
2008-08-04 21:32 ` Lennert Buytenhek
2008-08-04 21:45 ` Woodruff, Richard
2008-08-04 21:49 ` Lennert Buytenhek
2008-08-04 22:10 ` Woodruff, Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808041302.46323.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=kmpark@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nskamat@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox