From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] MTD: OMAP2-NAND: Fix partition reading from board info Date: Mon, 4 Aug 2008 17:24:30 +0300 Message-ID: <20080804142426.GK8885@atomide.com> References: <9c9fda240807011627v60428f9eh3c2bb17cdc8ce6ea@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:58635 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753520AbYHDOYr (ORCPT ); Mon, 4 Aug 2008 10:24:47 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Kamat, Nishant" Cc: "linux-mtd@lists.infradead.org" , "linux-omap@vger.kernel.org" , Kyungmin Park * Kamat, Nishant [080703 14:55]: > Hi, > > > > Kyungmin Park on July 02, 2008 4:57 AM, wrote: > > > > Hi, > > > > It's should be sent to MTD list. and we also fix the NOR similar ways. > > It's already posted but not committed. > > > Posting the patch on MTD list. Please merge. Looks like this driver does not exist outside linux-omap tree, care to send the whole driver to MTD list? Pushing this fix to linux-omap tree meanwhile. Tony > ---< Cut here >--- > > From: Nishant Kamat > > This patch fixes the omap2 nand driver code that allows > reading of partition data from board info. > > The parse_mtd_partitions() function no longer returns a > negative error in case cmdline is not passed. > See commit: b0d06afb607 > > Signed-off-by: Nishant Kamat > --- > drivers/mtd/nand/omap2.c | 2 +- > 1 files changed, 1 insertion(+), 1 deletion(-) > > Index: linux-omap-ti.ldp/drivers/mtd/nand/omap2.c > =================================================================== > --- linux-omap-ti.ldp.orig/drivers/mtd/nand/omap2.c 2008-06-30 22:01:50.000000000 +0530 > +++ linux-omap-ti.ldp/drivers/mtd/nand/omap2.c 2008-06-30 22:03:34.446471469 +0530 > @@ -699,7 +699,7 @@ > err = parse_mtd_partitions(&info->mtd, part_probes, &info->parts, 0); > if (err > 0) > add_mtd_partitions(&info->mtd, info->parts, err); > - else if (err < 0 && pdata->parts) > + else if (pdata->parts) > add_mtd_partitions(&info->mtd, pdata->parts, pdata->nr_parts); > else > #endif