From: David Brownell <david-b@pacbell.net>
To: "Kumar, Purushotam" <purushotam@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Purushotam Kumar <a0876542@india.ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Gole, Anant" <anantgole@ti.com>
Subject: Re: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
Date: Tue, 5 Aug 2008 00:10:14 -0700 [thread overview]
Message-ID: <200808050010.15117.david-b@pacbell.net> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB5930111B215C5@dbde02.ent.ti.com>
On Monday 14 July 2008, Kumar, Purushotam wrote:
> > > > if (cpu_is_omap2430() || cpu_is_omap34xx()) {
> > > > - if (mmc->enabled)
> > > > + if (mmc->enabled) {
> > > > + mmc1_data.conf = *mmc;
> > > > (void) platform_device_register(&mmc_omap_device1);
> > > > + }
I don't get it. OMAP3 uses the hsmmc code, which uses
a "struct omap_mmc_platform_data" to configure itself.
But this patch updates a "struct omap_mmc_conf" as used
by the non-hsmmc code.
So ... it's a NOP, at least for OMAP3. Right?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-08-05 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 13:02 [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card Purushotam Kumar
2008-06-23 12:47 ` Tony Lindgren
2008-06-25 10:04 ` Kumar, Purushotam
2008-07-14 11:56 ` Kumar, Purushotam
2008-08-05 7:10 ` David Brownell [this message]
2008-08-11 5:14 ` Madhusudhan Chikkature
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808050010.15117.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=a0876542@india.ti.com \
--cc=anantgole@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=purushotam@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox