public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 2.6.26-omap-git] beagle LED fixes
@ 2008-08-05  6:56 David Brownell
  2008-08-05  8:13 ` Koen Kooi
  0 siblings, 1 reply; 3+ messages in thread
From: David Brownell @ 2008-08-05  6:56 UTC (permalink / raw)
  To: linux-omap

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Update and fix Beagle LED declarations:  gpios for USR0 and USR1
were swapped, and their names don't match docs or silksreen.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
 arch/arm/mach-omap2/board-omap3beagle.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

--- a/arch/arm/mach-omap2/board-omap3beagle.c	2008-08-04 22:08:16.000000000 -0700
+++ b/arch/arm/mach-omap2/board-omap3beagle.c	2008-08-04 22:08:36.000000000 -0700

@@ -75,14 +76,14 @@ static struct omap_lcd_config omap3_beag
 
 struct gpio_led gpio_leds[] = {
 	{
-		.name			= "beagleboard::led0",
+		.name			= "beagleboard::usr0",
 		.default_trigger	= "none",
-		.gpio			= 149,
+		.gpio			= 150,
 	},
 	{
-		.name			= "beagleboard::led1",
+		.name			= "beagleboard::usr1",
 		.default_trigger	= "none",
-		.gpio			= 150,
+		.gpio			= 149,
 	},
 };
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch 2.6.26-omap-git] beagle LED fixes
  2008-08-05  6:56 [patch 2.6.26-omap-git] beagle LED fixes David Brownell
@ 2008-08-05  8:13 ` Koen Kooi
  2008-08-05  8:24   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Koen Kooi @ 2008-08-05  8:13 UTC (permalink / raw)
  To: David Brownell; +Cc: linux-omap

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]


Op 5 aug 2008, om 08:56 heeft David Brownell het volgende geschreven:

> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> Update and fix Beagle LED declarations:  gpios for USR0 and USR1
> were swapped, and their names don't match docs or silksreen.

I just heard that from TI and wanted to fix that today :) I didn't  
notice it because revA board have the leds shorted together so they  
both light up at the same time.

> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Acked-by: Koen Kooi <koen@openembedded.org>

>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c |    9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> --- a/arch/arm/mach-omap2/board-omap3beagle.c	2008-08-04  
> 22:08:16.000000000 -0700
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c	2008-08-04  
> 22:08:36.000000000 -0700
>
> @@ -75,14 +76,14 @@ static struct omap_lcd_config omap3_beag
>
> struct gpio_led gpio_leds[] = {
> 	{
> -		.name			= "beagleboard::led0",
> +		.name			= "beagleboard::usr0",
> 		.default_trigger	= "none",
> -		.gpio			= 149,
> +		.gpio			= 150,
> 	},
> 	{
> -		.name			= "beagleboard::led1",
> +		.name			= "beagleboard::usr1",
> 		.default_trigger	= "none",
> -		.gpio			= 150,
> +		.gpio			= 149,
> 	},
> };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux- 
> omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 186 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch 2.6.26-omap-git] beagle LED fixes
  2008-08-05  8:13 ` Koen Kooi
@ 2008-08-05  8:24   ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2008-08-05  8:24 UTC (permalink / raw)
  To: Koen Kooi; +Cc: David Brownell, linux-omap

* Koen Kooi <k.kooi@student.utwente.nl> [080805 11:14]:
>
> Op 5 aug 2008, om 08:56 heeft David Brownell het volgende geschreven:
>
>> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>>
>> Update and fix Beagle LED declarations:  gpios for USR0 and USR1
>> were swapped, and their names don't match docs or silksreen.
>
> I just heard that from TI and wanted to fix that today :) I didn't  
> notice it because revA board have the leds shorted together so they both 
> light up at the same time.

Pushing today.

Tony

>
>> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> Acked-by: Koen Kooi <koen@openembedded.org>
>
>>
>> ---
>> arch/arm/mach-omap2/board-omap3beagle.c |    9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> --- a/arch/arm/mach-omap2/board-omap3beagle.c	2008-08-04  
>> 22:08:16.000000000 -0700
>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c	2008-08-04  
>> 22:08:36.000000000 -0700
>>
>> @@ -75,14 +76,14 @@ static struct omap_lcd_config omap3_beag
>>
>> struct gpio_led gpio_leds[] = {
>> 	{
>> -		.name			= "beagleboard::led0",
>> +		.name			= "beagleboard::usr0",
>> 		.default_trigger	= "none",
>> -		.gpio			= 149,
>> +		.gpio			= 150,
>> 	},
>> 	{
>> -		.name			= "beagleboard::led1",
>> +		.name			= "beagleboard::usr1",
>> 		.default_trigger	= "none",
>> -		.gpio			= 150,
>> +		.gpio			= 149,
>> 	},
>> };
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" 
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-08-05  8:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-05  6:56 [patch 2.6.26-omap-git] beagle LED fixes David Brownell
2008-08-05  8:13 ` Koen Kooi
2008-08-05  8:24   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox