public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: andrzej zaborowski <balrogg@gmail.com>,
	"me@felipebalbi.com" <me@felipebalbi.com>,
	"Woodruff, Richard" <r-woodruff2@ti.com>,
	Carlos Aguiar <carlos.aguiar@indt.org.br>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus
Date: Tue, 5 Aug 2008 11:57:53 +0300	[thread overview]
Message-ID: <20080805085752.GE7193@atomide.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB02567D91E5@dbde02.ent.ti.com>

* Gadiyar, Anand <gadiyar@ti.com> [080729 22:38]:
> > 2008/7/29 Felipe Balbi <me@felipebalbi.com>:
> >> On Tue, Jul 29, 2008 at 02:07:51PM -0500, Woodruff, Richard wrote:
> >>> > How about renaming it to twl92230c before submitting upstream?  As far
> >>> > as I can tell the name menelaus appears only in linux and makes it
> >>> > hard to associate with the real hardware.  Does someone know why was
> >>> > it renamed that way?
> >>
> >>> A number does seem more understandable.  Though some of these chips live under a few different numbers.
> >>
> >> it does seem more understandable, but now that it has been used for so
> >> long I guess it would be nasty to change right now. Almost every one
> >> here knows that menelaus is the companion chip for omap2 hw. Personally,
> >> I never recall the correct number designation for menelaus.
> >
> > Well, menelaus is a friendly name now that I know what it is but it
> > was difficult to find its datasheet without knowing the public name
> > used by the manufacturer, it seemed like a nokia's own chip. Also iirc
> > if you open the device you will only see the TWLxxx name on the chip.
> >
> > I see TWLxxx is now mentioned in the Kconfig so I won't insist.
> >
> > Cheers
> 
> I think it'll be hard for a newbie to figure out what this menelaus is. Google
> won't help either, (unless one really thinks there is a connection between
> Linux and Greek Mythology ;) ).
> 
> I second renaming the file to TWL92230. Mentioning this in Kconfig is simply
> not enough.

Yeah, let's rename it as it's not in mainline yet. I'll apply this
series, then the next set of patches can take care of the renaming.

Tony

  parent reply	other threads:[~2008-08-05  8:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-29 16:44 [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus Carlos Aguiar
2008-07-29 18:37 ` Felipe Balbi
2008-07-29 18:57   ` andrzej zaborowski
2008-07-29 19:07     ` Woodruff, Richard
2008-07-29 19:18       ` Felipe Balbi
2008-07-29 19:28         ` andrzej zaborowski
2008-07-29 19:37           ` Gadiyar, Anand
2008-07-29 21:51             ` Felipe Balbi
2008-08-05  8:57             ` Tony Lindgren [this message]
2008-08-05  9:35               ` Felipe Balbi
2008-08-05  9:42                 ` Tony Lindgren
2008-08-05 13:38                   ` Carlos Aguiar
2008-08-05 13:45                     ` Tony Lindgren
2008-08-05 12:42                 ` Trilok Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080805085752.GE7193@atomide.com \
    --to=tony@atomide.com \
    --cc=balrogg@gmail.com \
    --cc=carlos.aguiar@indt.org.br \
    --cc=gadiyar@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=me@felipebalbi.com \
    --cc=r-woodruff2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox