[PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Carlos Aguiar]

Hi Tony and folks,

This patch series proposes some improvements on menelaus code.

Basically it makes menelaus to use macros instead of some magic constant 
numbers, making menelaus code more legible. The menelaus header was 
moved to include/linux/i2c and register map (including the macros 
created) were moved to include/linux/i2c/menelaus.h

Tested with MMC on N800 and looks fine.

BR,

Carlos.

PS: I would like to thanks Felipe Balbi for hints and orientation.

-- 
Carlos Eduardo Aguiar
Software Engineer
Mobile Linux Software
Nokia Institute of Technology - INdT
Phone: +55 92 2126-1079
Mobile: +55 92 8127-1797
E-mail: carlos.aguiar@indt.org.br

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Felipe Balbi]

On Tue, Jul 29, 2008 at 12:44:19PM -0400, Carlos Aguiar wrote:
> Hi Tony and folks,
>
> This patch series proposes some improvements on menelaus code.
>
> Basically it makes menelaus to use macros instead of some magic constant  
> numbers, making menelaus code more legible. The menelaus header was  
> moved to include/linux/i2c and register map (including the macros  
> created) were moved to include/linux/i2c/menelaus.h
>
> Tested with MMC on N800 and looks fine.

They look quite ok. How about syncing l-o menelaus with mainline via
lm-sensors mailing list and discuss all these there as well ??

It'd be only one extra patch before this one to make everything in sync.

-- 
balbi

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[andrzej zaborowski]

Hi,

2008/7/29 Felipe Balbi <me@felipebalbi.com>:
> On Tue, Jul 29, 2008 at 12:44:19PM -0400, Carlos Aguiar wrote:
>> Hi Tony and folks,
>>
>> This patch series proposes some improvements on menelaus code.
>>
>> Basically it makes menelaus to use macros instead of some magic constant
>> numbers, making menelaus code more legible. The menelaus header was
>> moved to include/linux/i2c and register map (including the macros
>> created) were moved to include/linux/i2c/menelaus.h
>>
>> Tested with MMC on N800 and looks fine.
>
> They look quite ok. How about syncing l-o menelaus with mainline via
> lm-sensors mailing list and discuss all these there as well ??

How about renaming it to twl92230c before submitting upstream?  As far
as I can tell the name menelaus appears only in linux and makes it
hard to associate with the real hardware.  Does someone know why was
it renamed that way?

Regards

RE: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Woodruff, Richard]

> How about renaming it to twl92230c before submitting upstream?  As far
> as I can tell the name menelaus appears only in linux and makes it
> hard to associate with the real hardware.  Does someone know why was
> it renamed that way?

The name was just an internal project name for that IO companion chip.  It has the name Menelaus probably before it had a number designation.

A number does seem more understandable.  Though some of these chips live under a few different numbers.

Regards,
Richard W.

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Felipe Balbi]

On Tue, Jul 29, 2008 at 02:07:51PM -0500, Woodruff, Richard wrote:
> > How about renaming it to twl92230c before submitting upstream?  As far
> > as I can tell the name menelaus appears only in linux and makes it
> > hard to associate with the real hardware.  Does someone know why was
> > it renamed that way?

> A number does seem more understandable.  Though some of these chips live under a few different numbers.

it does seem more understandable, but now that it has been used for so
long I guess it would be nasty to change right now. Almost every one
here knows that menelaus is the companion chip for omap2 hw. Personally,
I never recall the correct number designation for menelaus.

I mean, I don't really have any problems in renaming the whole driver
from menelaus to twl92230c.c but I can't help asking myself why. If
everybody thinks it's a better choice, then why not ;-)

-- 
balbi

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[andrzej zaborowski]

2008/7/29 Felipe Balbi <me@felipebalbi.com>:
> On Tue, Jul 29, 2008 at 02:07:51PM -0500, Woodruff, Richard wrote:
>> > How about renaming it to twl92230c before submitting upstream?  As far
>> > as I can tell the name menelaus appears only in linux and makes it
>> > hard to associate with the real hardware.  Does someone know why was
>> > it renamed that way?
>
>> A number does seem more understandable.  Though some of these chips live under a few different numbers.
>
> it does seem more understandable, but now that it has been used for so
> long I guess it would be nasty to change right now. Almost every one
> here knows that menelaus is the companion chip for omap2 hw. Personally,
> I never recall the correct number designation for menelaus.

Well, menelaus is a friendly name now that I know what it is but it
was difficult to find its datasheet without knowing the public name
used by the manufacturer, it seemed like a nokia's own chip. Also iirc
if you open the device you will only see the TWLxxx name on the chip.

I see TWLxxx is now mentioned in the Kconfig so I won't insist.

Cheers

RE: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Gadiyar, Anand]

> 2008/7/29 Felipe Balbi <me@felipebalbi.com>:
>> On Tue, Jul 29, 2008 at 02:07:51PM -0500, Woodruff, Richard wrote:
>>> > How about renaming it to twl92230c before submitting upstream?  As far
>>> > as I can tell the name menelaus appears only in linux and makes it
>>> > hard to associate with the real hardware.  Does someone know why was
>>> > it renamed that way?
>>
>>> A number does seem more understandable.  Though some of these chips live under a few different numbers.
>>
>> it does seem more understandable, but now that it has been used for so
>> long I guess it would be nasty to change right now. Almost every one
>> here knows that menelaus is the companion chip for omap2 hw. Personally,
>> I never recall the correct number designation for menelaus.
>
> Well, menelaus is a friendly name now that I know what it is but it
> was difficult to find its datasheet without knowing the public name
> used by the manufacturer, it seemed like a nokia's own chip. Also iirc
> if you open the device you will only see the TWLxxx name on the chip.
>
> I see TWLxxx is now mentioned in the Kconfig so I won't insist.
>
> Cheers

I think it'll be hard for a newbie to figure out what this menelaus is. Google
won't help either, (unless one really thinks there is a connection between
Linux and Greek Mythology ;) ).

I second renaming the file to TWL92230. Mentioning this in Kconfig is simply
not enough.

My 375 million ZWD,
Anand

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Felipe Balbi]

On Wed, Jul 30, 2008 at 01:07:35AM +0530, Gadiyar, Anand wrote:
> I think it'll be hard for a newbie to figure out what this menelaus is. Google
> won't help either, (unless one really thinks there is a connection between
> Linux and Greek Mythology ;) ).

eheh, That's true :-)

> I second renaming the file to TWL92230. Mentioning this in Kconfig is simply
> not enough.

Hmm... are there any other devices which would work with the same
driver ?

-- 
balbi

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Tony Lindgren]

* Gadiyar, Anand <gadiyar@ti.com> [080729 22:38]:
> > 2008/7/29 Felipe Balbi <me@felipebalbi.com>:
> >> On Tue, Jul 29, 2008 at 02:07:51PM -0500, Woodruff, Richard wrote:
> >>> > How about renaming it to twl92230c before submitting upstream?  As far
> >>> > as I can tell the name menelaus appears only in linux and makes it
> >>> > hard to associate with the real hardware.  Does someone know why was
> >>> > it renamed that way?
> >>
> >>> A number does seem more understandable.  Though some of these chips live under a few different numbers.
> >>
> >> it does seem more understandable, but now that it has been used for so
> >> long I guess it would be nasty to change right now. Almost every one
> >> here knows that menelaus is the companion chip for omap2 hw. Personally,
> >> I never recall the correct number designation for menelaus.
> >
> > Well, menelaus is a friendly name now that I know what it is but it
> > was difficult to find its datasheet without knowing the public name
> > used by the manufacturer, it seemed like a nokia's own chip. Also iirc
> > if you open the device you will only see the TWLxxx name on the chip.
> >
> > I see TWLxxx is now mentioned in the Kconfig so I won't insist.
> >
> > Cheers
> 
> I think it'll be hard for a newbie to figure out what this menelaus is. Google
> won't help either, (unless one really thinks there is a connection between
> Linux and Greek Mythology ;) ).
> 
> I second renaming the file to TWL92230. Mentioning this in Kconfig is simply
> not enough.

Yeah, let's rename it as it's not in mainline yet. I'll apply this
series, then the next set of patches can take care of the renaming.

Tony

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Felipe Balbi]

On Tue, Aug 05, 2008 at 11:57:53AM +0300, Tony Lindgren wrote:
> Yeah, let's rename it as it's not in mainline yet. I'll apply this
> series, then the next set of patches can take care of the renaming.

It it in mainline actually, check your drivers/i2c/chips and it was
added by you :-p

commit 0c4a59fed41bdd4c30ce0999a87f30a812f29ee2
Author: Tony Lindgren <tony@atomide.com>
Date:   Tue Jul 17 04:06:09 2007 -0700

    OMAP: add TI TWL92330/Menelaus Power Management chip driver
    
    Add Texas Instruments TWL92330/Menelaus Power Management chip driver.  This
    includes voltage regulators, Dual slot memory card tranceivers and
    real-time clock(RTC).
    
    The support for RTC is integrated with this driver only; it is not separate
    module.  Passes 'rtctest' on OMAP H4 EVM, other than lack of "periodic"
    (1/N second) IRQs.  System wakeup alarms (from suspend-to-RAM) work too.
    
    The battery keeps the RTC active over power off, so once you set clock
    (rdate/ntpdate/etc, then "hwclock -w") then RTC_HCTOSYS at boot time will
    behave as expected.
    
    Cc: "Jean Delvare" <khali@linux-fr.org>
    Cc: "Tony Lindgren" <tony@atomide.com>
    Cc: "David Brownell" <david-b@pacbell.net>
    Signed-off-by: Trilok Soni <soni.trilok@gmail.com>
    Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Maybe someone sent that patch for you ?

-- 
balbi

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Tony Lindgren]

* Felipe Balbi <felipe.balbi@nokia.com> [080805 12:35]:
> On Tue, Aug 05, 2008 at 11:57:53AM +0300, Tony Lindgren wrote:
> > Yeah, let's rename it as it's not in mainline yet. I'll apply this
> > series, then the next set of patches can take care of the renaming.
> 
> It it in mainline actually, check your drivers/i2c/chips and it was
> added by you :-p
> 
> commit 0c4a59fed41bdd4c30ce0999a87f30a812f29ee2
> Author: Tony Lindgren <tony@atomide.com>
> Date:   Tue Jul 17 04:06:09 2007 -0700
> 
>     OMAP: add TI TWL92330/Menelaus Power Management chip driver
>     
>     Add Texas Instruments TWL92330/Menelaus Power Management chip driver.  This
>     includes voltage regulators, Dual slot memory card tranceivers and
>     real-time clock(RTC).
>     
>     The support for RTC is integrated with this driver only; it is not separate
>     module.  Passes 'rtctest' on OMAP H4 EVM, other than lack of "periodic"
>     (1/N second) IRQs.  System wakeup alarms (from suspend-to-RAM) work too.
>     
>     The battery keeps the RTC active over power off, so once you set clock
>     (rdate/ntpdate/etc, then "hwclock -w") then RTC_HCTOSYS at boot time will
>     behave as expected.
>     
>     Cc: "Jean Delvare" <khali@linux-fr.org>
>     Cc: "Tony Lindgren" <tony@atomide.com>
>     Cc: "David Brownell" <david-b@pacbell.net>
>     Signed-off-by: Trilok Soni <soni.trilok@gmail.com>
>     Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> 
> Maybe someone sent that patch for you ?

Oops :) I guess I'm over a year behind current developments after my
vacation!

Anyways, sounds like people want to rename it. Carlos, can you
send your patches to the i2c list for integration?

Tony

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Trilok Soni]

Hi Felipe,

On Tue, Aug 5, 2008 at 3:05 PM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> On Tue, Aug 05, 2008 at 11:57:53AM +0300, Tony Lindgren wrote:
>> Yeah, let's rename it as it's not in mainline yet. I'll apply this
>> series, then the next set of patches can take care of the renaming.
>
> It it in mainline actually, check your drivers/i2c/chips and it was
> added by you :-p

Nope. It was added by me through I2C mailing list. :)

>
-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Carlos Aguiar]

ext Tony Lindgren wrote:
> * Felipe Balbi <felipe.balbi@nokia.com> [080805 12:35]:
>   
>> On Tue, Aug 05, 2008 at 11:57:53AM +0300, Tony Lindgren wrote:
>>     
>>> Yeah, let's rename it as it's not in mainline yet. I'll apply this
>>> series, then the next set of patches can take care of the renaming.
>>>       
>> It it in mainline actually, check your drivers/i2c/chips and it was
>> added by you :-p
>>
>> commit 0c4a59fed41bdd4c30ce0999a87f30a812f29ee2
>> Author: Tony Lindgren <tony@atomide.com>
>> Date:   Tue Jul 17 04:06:09 2007 -0700
>>
>>     OMAP: add TI TWL92330/Menelaus Power Management chip driver
>>     
>>     Add Texas Instruments TWL92330/Menelaus Power Management chip driver.  This
>>     includes voltage regulators, Dual slot memory card tranceivers and
>>     real-time clock(RTC).
>>     
>>     The support for RTC is integrated with this driver only; it is not separate
>>     module.  Passes 'rtctest' on OMAP H4 EVM, other than lack of "periodic"
>>     (1/N second) IRQs.  System wakeup alarms (from suspend-to-RAM) work too.
>>     
>>     The battery keeps the RTC active over power off, so once you set clock
>>     (rdate/ntpdate/etc, then "hwclock -w") then RTC_HCTOSYS at boot time will
>>     behave as expected.
>>     
>>     Cc: "Jean Delvare" <khali@linux-fr.org>
>>     Cc: "Tony Lindgren" <tony@atomide.com>
>>     Cc: "David Brownell" <david-b@pacbell.net>
>>     Signed-off-by: Trilok Soni <soni.trilok@gmail.com>
>>     Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it>
>>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>>
>> Maybe someone sent that patch for you ?
>>     
>
> Oops :) I guess I'm over a year behind current developments after my
> vacation!
>
> Anyways, sounds like people want to rename it. Carlos, can you
> send your patches to the i2c list for integration?
>
> Tony
>
>   
Hi Tony and folks,

So, I'm going to preparing and send a new series by today to i2c list 
for integration so that such series:

- Align the code from l-o tree to mainline tree.
- Apply the series of four patches I just sent to l-o.
- And than a last one to rename files to twl92230, as folks agreeded.

BR,

Carlos.


-- 
Carlos Eduardo Aguiar
Software Engineer
Mobile Linux Software
Nokia Institute of Technology - INdT
Phone: +55 92 2126-1079
Mobile: +55 92 8127-1797
E-mail: carlos.aguiar@indt.org.br

Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus

[Tony Lindgren]

* Carlos Aguiar <carlos.aguiar@indt.org.br> [080805 16:40]:
> ext Tony Lindgren wrote:
>> * Felipe Balbi <felipe.balbi@nokia.com> [080805 12:35]:
>>   
>>> On Tue, Aug 05, 2008 at 11:57:53AM +0300, Tony Lindgren wrote:
>>>     
>>>> Yeah, let's rename it as it's not in mainline yet. I'll apply this
>>>> series, then the next set of patches can take care of the renaming.
>>>>       
>>> It it in mainline actually, check your drivers/i2c/chips and it was
>>> added by you :-p
>>>
>>> commit 0c4a59fed41bdd4c30ce0999a87f30a812f29ee2
>>> Author: Tony Lindgren <tony@atomide.com>
>>> Date:   Tue Jul 17 04:06:09 2007 -0700
>>>
>>>     OMAP: add TI TWL92330/Menelaus Power Management chip driver
>>>         Add Texas Instruments TWL92330/Menelaus Power Management chip 
>>> driver.  This
>>>     includes voltage regulators, Dual slot memory card tranceivers and
>>>     real-time clock(RTC).
>>>         The support for RTC is integrated with this driver only; it 
>>> is not separate
>>>     module.  Passes 'rtctest' on OMAP H4 EVM, other than lack of "periodic"
>>>     (1/N second) IRQs.  System wakeup alarms (from suspend-to-RAM) work too.
>>>         The battery keeps the RTC active over power off, so once you 
>>> set clock
>>>     (rdate/ntpdate/etc, then "hwclock -w") then RTC_HCTOSYS at boot time will
>>>     behave as expected.
>>>         Cc: "Jean Delvare" <khali@linux-fr.org>
>>>     Cc: "Tony Lindgren" <tony@atomide.com>
>>>     Cc: "David Brownell" <david-b@pacbell.net>
>>>     Signed-off-by: Trilok Soni <soni.trilok@gmail.com>
>>>     Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it>
>>>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>>>
>>> Maybe someone sent that patch for you ?
>>>     
>>
>> Oops :) I guess I'm over a year behind current developments after my
>> vacation!
>>
>> Anyways, sounds like people want to rename it. Carlos, can you
>> send your patches to the i2c list for integration?
>>
>> Tony
>>
>>   
> Hi Tony and folks,
>
> So, I'm going to preparing and send a new series by today to i2c list  
> for integration so that such series:
>
> - Align the code from l-o tree to mainline tree.
> - Apply the series of four patches I just sent to l-o.
> - And than a last one to rename files to twl92230, as folks agreeded.

Sounds good to me!

Tony