From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 0/4] OMAP: MENELAUS: Improvements on menelaus Date: Tue, 5 Aug 2008 11:57:53 +0300 Message-ID: <20080805085752.GE7193@atomide.com> References: <488F48E3.2060504@indt.org.br> <20080729183717.GB7275@frodo> <13B9B4C6EF24D648824FF11BE89671620361D432D8@dlee02.ent.ti.com> <5A47E75E594F054BAF48C5E4FC4B92AB02567D91E5@dbde02.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:60949 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755621AbYHEI6E (ORCPT ); Tue, 5 Aug 2008 04:58:04 -0400 Content-Disposition: inline In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB02567D91E5@dbde02.ent.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Gadiyar, Anand" Cc: andrzej zaborowski , "me@felipebalbi.com" , "Woodruff, Richard" , Carlos Aguiar , "linux-omap@vger.kernel.org" * Gadiyar, Anand [080729 22:38]: > > 2008/7/29 Felipe Balbi : > >> On Tue, Jul 29, 2008 at 02:07:51PM -0500, Woodruff, Richard wrote: > >>> > How about renaming it to twl92230c before submitting upstream? As far > >>> > as I can tell the name menelaus appears only in linux and makes it > >>> > hard to associate with the real hardware. Does someone know why was > >>> > it renamed that way? > >> > >>> A number does seem more understandable. Though some of these chips live under a few different numbers. > >> > >> it does seem more understandable, but now that it has been used for so > >> long I guess it would be nasty to change right now. Almost every one > >> here knows that menelaus is the companion chip for omap2 hw. Personally, > >> I never recall the correct number designation for menelaus. > > > > Well, menelaus is a friendly name now that I know what it is but it > > was difficult to find its datasheet without knowing the public name > > used by the manufacturer, it seemed like a nokia's own chip. Also iirc > > if you open the device you will only see the TWLxxx name on the chip. > > > > I see TWLxxx is now mentioned in the Kconfig so I won't insist. > > > > Cheers > > I think it'll be hard for a newbie to figure out what this menelaus is. Google > won't help either, (unless one really thinks there is a connection between > Linux and Greek Mythology ;) ). > > I second renaming the file to TWL92230. Mentioning this in Kconfig is simply > not enough. Yeah, let's rename it as it's not in mainline yet. I'll apply this series, then the next set of patches can take care of the renaming. Tony