public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Free HDQ clocks in error path
@ 2008-07-22 12:03 Madhusudhan Chikkature
  2008-08-05 13:30 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Madhusudhan Chikkature @ 2008-07-22 12:03 UTC (permalink / raw)
  To: tony; +Cc: linux-omap

Hi,

This patch provides the fix to free the HDQ clocks in the error path.

Regards,
Madhu
-----------------------------------------------------------------

From: Madhusudhan Chikkature<madhu.cr@ti.com>

ARM: OMAP3: Free HDQ clocks when a read is tried with no battery connected

Signed-off-by: Madhusudhan Chikkature<madhu.cr@ti.com>
---
 drivers/w1/masters/omap_hdq.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletion(-)

Index: linux-omap-ti.git-07102008/drivers/w1/masters/omap_hdq.c
===================================================================
--- linux-omap-ti.git-07102008.orig/drivers/w1/masters/omap_hdq.c	2008-07-02
20:10:38.000000000 +0530
+++ linux-omap-ti.git-07102008/drivers/w1/masters/omap_hdq.c	2008-07-16
12:17:42.000000000 +0530
@@ -515,8 +515,11 @@ static u8 omap_w1_read_byte(void *data)
 	int ret;

 	ret = hdq_read_byte(&val);
-	if (ret)
+	if (ret) {
+		init_trans = 0;
+		omap_hdq_put();
 		return -1;
+	}

 	/* Write followed by a read, release the module */
 	if (init_trans) {



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Free HDQ clocks in error path
  2008-07-22 12:03 [PATCH] Free HDQ clocks in error path Madhusudhan Chikkature
@ 2008-08-05 13:30 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2008-08-05 13:30 UTC (permalink / raw)
  To: Madhusudhan Chikkature; +Cc: linux-omap

* Madhusudhan Chikkature <madhu.cr@ti.com> [080722 15:04]:
> Hi,
> 
> This patch provides the fix to free the HDQ clocks in the error path.
> 
> Regards,
> Madhu
> -----------------------------------------------------------------
> 
> From: Madhusudhan Chikkature<madhu.cr@ti.com>
> 
> ARM: OMAP3: Free HDQ clocks when a read is tried with no battery connected

Pushing today.

Tony


> Signed-off-by: Madhusudhan Chikkature<madhu.cr@ti.com>
> ---
>  drivers/w1/masters/omap_hdq.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletion(-)
> 
> Index: linux-omap-ti.git-07102008/drivers/w1/masters/omap_hdq.c
> ===================================================================
> --- linux-omap-ti.git-07102008.orig/drivers/w1/masters/omap_hdq.c	2008-07-02
> 20:10:38.000000000 +0530
> +++ linux-omap-ti.git-07102008/drivers/w1/masters/omap_hdq.c	2008-07-16
> 12:17:42.000000000 +0530
> @@ -515,8 +515,11 @@ static u8 omap_w1_read_byte(void *data)
>  	int ret;
> 
>  	ret = hdq_read_byte(&val);
> -	if (ret)
> +	if (ret) {
> +		init_trans = 0;
> +		omap_hdq_put();
>  		return -1;
> +	}
> 
>  	/* Write followed by a read, release the module */
>  	if (init_trans) {
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-05 13:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-22 12:03 [PATCH] Free HDQ clocks in error path Madhusudhan Chikkature
2008-08-05 13:30 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox