From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Woodruff, Richard" <r-woodruff2@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.arm.linux.org.uk"
<linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH] ARM MMU: add strongly-ordered memory type
Date: Thu, 7 Aug 2008 22:59:26 +0100 [thread overview]
Message-ID: <20080807215926.GJ5737@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080807212033.GH5737@flint.arm.linux.org.uk>
On Thu, Aug 07, 2008 at 10:20:33PM +0100, Russell King - ARM Linux wrote:
> In the case of arch/arm/mach-omap2/irq.c, reading the INTC_REVISION
> reg after masking should be a sufficient solution.
And here's a patch to do exactly that.
diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
index 9ef15b3..27610b1 100644
--- a/arch/arm/mach-omap2/irq.c
+++ b/arch/arm/mach-omap2/irq.c
@@ -48,6 +48,7 @@ static struct omap_irq_bank {
static void omap_ack_irq(unsigned int irq)
{
__raw_writel(0x1, irq_banks[0].base_reg + INTC_CONTROL);
+ __raw_readl(irq_banks[0].base_reg + INTC_REVISION);
}
static void omap_mask_irq(unsigned int irq)
@@ -61,6 +62,7 @@ static void omap_mask_irq(unsigned int irq)
}
__raw_writel(1 << irq, irq_banks[0].base_reg + INTC_MIR_SET0 + offset);
+ __raw_readl(irq_banks[0].base_reg + INTC_REVISION);
}
static void omap_unmask_irq(unsigned int irq)
next prev parent reply other threads:[~2008-08-07 21:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 23:40 [PATCH] ARM MMU: add strongly-ordered memory type Paul Walmsley
2008-08-05 11:49 ` Ben Dooks
2008-08-05 12:15 ` Woodruff, Richard
2008-08-06 10:20 ` Catalin Marinas
2008-08-06 12:28 ` Woodruff, Richard
2008-08-07 16:55 ` Catalin Marinas
2008-08-07 6:01 ` Paul Walmsley
2008-08-07 16:45 ` Catalin Marinas
2008-08-08 8:45 ` Paul Walmsley
2008-08-06 9:53 ` Catalin Marinas
2008-08-06 12:21 ` Woodruff, Richard
2008-08-07 7:30 ` Russell King - ARM Linux
2008-08-07 16:01 ` Catalin Marinas
2008-08-07 18:56 ` Woodruff, Richard
2008-08-07 19:25 ` Russell King - ARM Linux
2008-08-07 20:38 ` Woodruff, Richard
2008-08-07 21:20 ` Russell King - ARM Linux
2008-08-07 21:59 ` Russell King - ARM Linux [this message]
2008-08-07 23:07 ` Woodruff, Richard
2008-08-08 7:16 ` Russell King - ARM Linux
2008-08-08 11:44 ` Catalin Marinas
2008-08-08 13:19 ` Russell King - ARM Linux
2008-08-08 16:40 ` Catalin Marinas
2008-08-11 7:50 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080807215926.GJ5737@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=r-woodruff2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox