From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: ext chandra shekhar <x0044955@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/2] McBSP preamble patch for 34xx support,
Date: Fri, 8 Aug 2008 13:05:52 +0300 [thread overview]
Message-ID: <20080808100551.GQ24923@atomide.com> (raw)
In-Reply-To: <20080808125301.9b18c596.jarkko.nikula@nokia.com>
* Jarkko Nikula <jarkko.nikula@nokia.com> [080808 12:54]:
> On Fri, 8 Aug 2008 11:32:55 +0530 (IST)
> "ext chandra shekhar" <x0044955@ti.com> wrote:
>
> > Hi,
> >
> > This a preamble patch series for McBSP support on OAMP34xx. it adds
> > few register definitions and and base addresses for all the McBSP
> > instances. It also modifies read/write functions to do 16/32 ops
> > depending on CPU. It doesn't add any functionality.
> >
> Hi
>
> There's line wrapping on these two patches:
>
> Subject: [PATCH 1/2] McBSP preamble patch for 34xx support,
> Subject: [ Resending PATCH 2/2] McBSP preamble patch for 34xx support
>
> patching file arch/arm/mach-omap2/mcbsp.c
> patching file include/asm-arm/arch-omap/mcbsp.h
> patch: **** malformed patch at line 182: defined(CONFIG_ARCH_OMAP730)
>
> patching file arch/arm/plat-omap/mcbsp.c
> patching file include/asm-arm/arch-omap/mcbsp.h
> patch: **** malformed patch at line 117: OMAP_MCBSP_REG_##reg)
>
> They apply by correcting them manually and don't break ASoC on N810 :-)
OK, pushing today after manually editing them to apply. BTW, Chandra,
can you start sending your patches in format that apply directly with
git-am? That way I don't have to edit each patch manually to remove
the mail body.
You can easily generate patches in the right format from your git branch
with git-show --pretty=email some_commit_id.
Thanks,
Tony
prev parent reply other threads:[~2008-08-08 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 6:02 [PATCH 0/2] McBSP preamble patch for 34xx support, chandra shekhar
2008-08-08 9:53 ` Jarkko Nikula
2008-08-08 10:05 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080808100551.GQ24923@atomide.com \
--to=tony@atomide.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0044955@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox