[PATCH 0/2] McBSP preamble patch for 34xx support,

[PATCH 0/2] McBSP preamble patch for 34xx support,

[chandra shekhar]

Hi,

This a preamble patch series for McBSP support on OAMP34xx. it adds few
register definitions and and base addresses for all the McBSP instances.
It also modifies read/write functions to do 16/32 ops depending on CPU.
It doesn't add any functionality.

Regards,
Chandra Shekhar

Re: [PATCH 0/2] McBSP preamble patch for 34xx support,

[Jarkko Nikula]

On Fri, 8 Aug 2008 11:32:55 +0530 (IST)
"ext chandra shekhar" <x0044955@ti.com> wrote:

> Hi,
> 
> This a preamble patch series for McBSP support on OAMP34xx. it adds
> few register definitions and and base addresses for all the McBSP
> instances. It also modifies read/write functions to do 16/32 ops
> depending on CPU. It doesn't add any functionality.
> 
Hi

There's line wrapping on these two patches:

Subject: [PATCH 1/2]  McBSP preamble patch for 34xx support,
Subject:  [ Resending PATCH 2/2]  McBSP preamble patch for 34xx support

patching file arch/arm/mach-omap2/mcbsp.c
patching file include/asm-arm/arch-omap/mcbsp.h
patch: **** malformed patch at line 182: defined(CONFIG_ARCH_OMAP730)

patching file arch/arm/plat-omap/mcbsp.c
patching file include/asm-arm/arch-omap/mcbsp.h
patch: **** malformed patch at line 117: OMAP_MCBSP_REG_##reg)

They apply by correcting them manually and don't break ASoC on N810 :-)


Jarkko

Re: [PATCH 0/2] McBSP preamble patch for 34xx support,

[Tony Lindgren]

* Jarkko Nikula <jarkko.nikula@nokia.com> [080808 12:54]:
> On Fri, 8 Aug 2008 11:32:55 +0530 (IST)
> "ext chandra shekhar" <x0044955@ti.com> wrote:
> 
> > Hi,
> > 
> > This a preamble patch series for McBSP support on OAMP34xx. it adds
> > few register definitions and and base addresses for all the McBSP
> > instances. It also modifies read/write functions to do 16/32 ops
> > depending on CPU. It doesn't add any functionality.
> > 
> Hi
> 
> There's line wrapping on these two patches:
> 
> Subject: [PATCH 1/2]  McBSP preamble patch for 34xx support,
> Subject:  [ Resending PATCH 2/2]  McBSP preamble patch for 34xx support
> 
> patching file arch/arm/mach-omap2/mcbsp.c
> patching file include/asm-arm/arch-omap/mcbsp.h
> patch: **** malformed patch at line 182: defined(CONFIG_ARCH_OMAP730)
> 
> patching file arch/arm/plat-omap/mcbsp.c
> patching file include/asm-arm/arch-omap/mcbsp.h
> patch: **** malformed patch at line 117: OMAP_MCBSP_REG_##reg)
> 
> They apply by correcting them manually and don't break ASoC on N810 :-)

OK, pushing today after manually editing them to apply. BTW, Chandra,
can you start sending your patches in format that apply directly with
git-am? That way I don't have to edit each patch manually to remove
the mail body.

You can easily generate patches in the right format from your git branch
with git-show --pretty=email some_commit_id.

Thanks,

Tony