From: David Brownell <david-b@pacbell.net>
To: Tony Lindgren <tony@atomide.com>, Arun KS <arunks@mistralsolutions.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP2EVM: Adding hsmmc support
Date: Fri, 8 Aug 2008 15:33:41 -0700 [thread overview]
Message-ID: <200808081533.42172.david-b@pacbell.net> (raw)
In-Reply-To: <20080808074927.GK24923@atomide.com>
As I commented in
http://marc.info/?l=linux-omap&m=121792042504348&w=2
I can't quite see why anything is using "omap_mmc_config" for
anything related to hsmmc ... it contains two structs that
don't match what the hsmmc driver understands.
- Dave
> > @@ -83,9 +84,17 @@ static struct omap_uart_config
> > omap2_evm_uart_config __initdata = {
> > .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)),
> > };
> >
> > +static struct omap_mmc_config omap2_evm_mmc_config __initdata = {
> > + .mmc [0] = {
> > + .enabled = 1,
> > + .wire4 = 1,
> > + },
> > +};
> > +
> > static struct omap_board_config_kernel omap2_evm_config[] __initdata = {
> > { OMAP_TAG_UART, &omap2_evm_uart_config },
> > { OMAP_TAG_LCD, &omap2_evm_lcd_config },
> > + { OMAP_TAG_MMC, &omap2_evm_mmc_config },
> > };
> >
> > static int __init omap2_evm_i2c_init(void)
next prev parent reply other threads:[~2008-08-08 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 11:19 [PATCH] OMAP2EVM: Adding hsmmc support Arun KS
2008-08-08 7:49 ` Tony Lindgren
2008-08-08 22:33 ` David Brownell [this message]
2008-08-11 5:22 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808081533.42172.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=arunks@mistralsolutions.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox