From: Felipe Balbi <me@felipebalbi.com>
To: Greg KH <gregkh@suse.de>
Cc: Felipe Balbi <me@felipebalbi.com>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Felipe Balbi <felipe.balbi@nokia.com>,
Anand Gadiyar <gadiyar@ti.com>, Bryan Wu <bryan.wu@analog.com>,
David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH] usb: musb: get rid of MUSB_LOGLEVEL and use parameter
Date: Sun, 10 Aug 2008 20:56:51 +0300 [thread overview]
Message-ID: <20080810175650.GI7574@frodo> (raw)
In-Reply-To: <20080810175319.GA24358@suse.de>
On Sun, Aug 10, 2008 at 10:53:19AM -0700, Greg KH wrote:
> On Sun, Aug 10, 2008 at 03:20:46PM +0300, Felipe Balbi wrote:
> > From: Felipe Balbi <felipe.balbi@nokia.com>
> >
> > We can change debugging level on the fly via
> > /sys/module/musb_hdrc/parameters/debug, there's no
> > need for an extra command in the proc entry.
>
> Why are there any proc files in this driver? Drivers should not add
> proc files. Hm, should have reviewed this code a bit better, sorry...
We needed a quick way to export the testmodes to userland. And it's been
used for that.
> Can you please just remove them all?
Yeah, I'm moving them to debugfs. I can remove everything and later add
only the debugfs if you like.
--
balbi
next prev parent reply other threads:[~2008-08-10 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-10 12:20 [PATCH] usb: musb: get rid of MUSB_LOGLEVEL and use parameter Felipe Balbi
2008-08-10 17:53 ` Greg KH
2008-08-10 17:56 ` Felipe Balbi [this message]
2008-08-10 18:37 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080810175650.GI7574@frodo \
--to=me@felipebalbi.com \
--cc=bryan.wu@analog.com \
--cc=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=gregkh@suse.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox