From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: DMA: Fix uninitialized channel flags
Date: Mon, 18 Aug 2008 15:15:05 +0300 [thread overview]
Message-ID: <20080818121501.GB17827@atomide.com> (raw)
In-Reply-To: <1219051702-25944-1-git-send-email-jarkko.nikula@nokia.com>
* Jarkko Nikula <jarkko.nikula@nokia.com> [080818 12:53]:
> This has similar symptoms than 66c23551b1b774e2be3c7bdf91c0ebf2c7a3519e
> where just omap_request_dma, omap_dma_link_lch and omap_dma_unlink_lch
> can cause incorrect dump_stack(). Here it can happen if channel has been
> used before and the channel flags variable holds old status.
Pushing today.
Tony
> Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> ---
> arch/arm/plat-omap/dma.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> index a63b644..1c6b905 100644
> --- a/arch/arm/plat-omap/dma.c
> +++ b/arch/arm/plat-omap/dma.c
> @@ -712,6 +712,7 @@ int omap_request_dma(int dev_id, const char *dev_name,
> chan->dev_name = dev_name;
> chan->callback = callback;
> chan->data = data;
> + chan->flags = 0;
>
> #ifndef CONFIG_ARCH_OMAP1
> if (cpu_class_is_omap2()) {
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-08-18 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 9:28 [PATCH] ARM: OMAP: DMA: Fix uninitialized channel flags Jarkko Nikula
2008-08-18 12:15 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818121501.GB17827@atomide.com \
--to=tony@atomide.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox