[PATCH] ARM: OMAP: DMA: Fix uninitialized channel flags

[PATCH] ARM: OMAP: DMA: Fix uninitialized channel flags

[Jarkko Nikula]

This has similar symptoms than 66c23551b1b774e2be3c7bdf91c0ebf2c7a3519e
where just omap_request_dma, omap_dma_link_lch and omap_dma_unlink_lch
can cause incorrect dump_stack(). Here it can happen if channel has been
used before and the channel flags variable holds old status.

Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
---
 arch/arm/plat-omap/dma.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index a63b644..1c6b905 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -712,6 +712,7 @@ int omap_request_dma(int dev_id, const char *dev_name,
 	chan->dev_name = dev_name;
 	chan->callback = callback;
 	chan->data = data;
+	chan->flags = 0;
 
 #ifndef CONFIG_ARCH_OMAP1
 	if (cpu_class_is_omap2()) {
-- 
1.5.6.3

Re: [PATCH] ARM: OMAP: DMA: Fix uninitialized channel flags

[Tony Lindgren]

* Jarkko Nikula <jarkko.nikula@nokia.com> [080818 12:53]:
> This has similar symptoms than 66c23551b1b774e2be3c7bdf91c0ebf2c7a3519e
> where just omap_request_dma, omap_dma_link_lch and omap_dma_unlink_lch
> can cause incorrect dump_stack(). Here it can happen if channel has been
> used before and the channel flags variable holds old status.

Pushing today.

Tony

> Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> ---
>  arch/arm/plat-omap/dma.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> index a63b644..1c6b905 100644
> --- a/arch/arm/plat-omap/dma.c
> +++ b/arch/arm/plat-omap/dma.c
> @@ -712,6 +712,7 @@ int omap_request_dma(int dev_id, const char *dev_name,
>  	chan->dev_name = dev_name;
>  	chan->callback = callback;
>  	chan->data = data;
> +	chan->flags = 0;
>  
>  #ifndef CONFIG_ARCH_OMAP1
>  	if (cpu_class_is_omap2()) {
> -- 
> 1.5.6.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html