Re: [PATCH] Fix isp1301_omap compile (Re: testers wanted: isp1301_omap conversion to new-style i2c driver)

[Tony Lindgren <tony@atomide.com>]

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

* Jean Delvare <khali@linux-fr.org> [080812 12:52]:
> Hi Tony,
> 
> On Tue, 12 Aug 2008 12:29:18 +0300, Tony Lindgren wrote:
> > * David Brownell <david-b@pacbell.net> [080811 21:35]:
> > > > That one isn't mine, the original code already has the problem.
> > > > Apparently this was broken by the following patch from David:
> > > >
> > > > 	f35ae6346850f6c192269b09088b20261760f0e0
> > > 
> > > Tony, actually ... there were some issues in the omap_udc code too.
> > 
> > Yeah, blame it on me, looks like I missed that one somehow with the
> > __REG removal.
> > 
> > > > The fix should be sent to Linus ASAP, otherwise the driver won't build
> > > > in 2.6.27. You have my ack.
> > 
> > Can you send it via your I2C? Let me know if your want me to send it
> > via arm-omap fixes.
> 
> Please take care of it. The patch that broke the driver came through
> your tree so I think it makes more sense to have the fix come through
> your tree as well.

Well looks like there's already cbbcb9b0c7e4d1fd90cf54427382dae525773dc2
taking care of it the second part of my earlier patch.

But the following patch still needs to be merged into Felipe's
"2c/isp1301_omap: Convert to a new-style i2c driver, part 1" patch.

Tony

[-- Attachment #2: i2c-fix-dev-get-drvdata --]
[-- Type: text/plain, Size: 704 bytes --]

commit d12a00e66e97f2e808217eb3e9c9e88d4a281530
Author: Tony Lindgren <tony@atomide.com>
Date:   Mon Aug 11 17:45:32 2008 +0300

    I2C: Fix isp1301_omap.c compile
    
    Fix isp1301_omap.c compile
    
    Signed-off-by: Tony Lindgren <tony@atomide.com>

diff --git a/drivers/i2c/chips/isp1301_omap.c b/drivers/i2c/chips/isp1301_omap.c
index c250668..71a0a2e 100644
--- a/drivers/i2c/chips/isp1301_omap.c
+++ b/drivers/i2c/chips/isp1301_omap.c
@@ -1210,7 +1210,7 @@ static void isp1301_release(struct device *dev)
 {
 	struct isp1301	*isp;
 
-	isp = device_get_drvdata(dev);
+	isp = dev_get_drvdata(dev);
 
 	/* ugly -- i2c hijacks our memory hook to wait_for_completion() */
 	if (isp->i2c_release)